Fix potentially unclosed file in runtimeVM#CreateContainer #3953
Conversation
|
/approve thanks @tedyu LGTM |
Codecov Report
@@ Coverage Diff @@
## master #3953 +/- ##
==========================================
- Coverage 40.53% 40.52% -0.01%
==========================================
Files 109 109
Lines 8832 8834 +2
==========================================
Hits 3580 3580
- Misses 4927 4929 +2
Partials 325 325 |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert, tedyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -141,6 +141,7 @@ func (r *runtimeVM) CreateContainer(c *Container, cgroupParent string) (err erro | |||
|
|
|||
| select { | |||
| case err = <-createdCh: | |||
| f.Close() | |||
There was a problem hiding this comment.
how is the file closed in the timeout case?
There was a problem hiding this comment.
I think similar handling should be done in timeout case.
Should I include that change in this PR ?
There was a problem hiding this comment.
yeah can you include it in this PR?
There was a problem hiding this comment.
I have updated the PR
|
/area vm |
|
@saschagrunert: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
|
LGTM @fidencio PTAL |
|
lgtm! |
|
/lgtm |
|
@tedyu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/cherry-pick release-1.18 |
|
@fidencio: only cri-o org members may request cherry picks. You can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.18 |
|
@fidencio: new pull request created: #3961 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.17 |
|
@fidencio: new pull request created: #3962 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If the r.task.Create() call fails on line 135, the file would be unclosed.
Which issue(s) this PR fixes:
Fixes #3899
Does this PR introduce a user-facing change?