8000 feat: sign verify rawdata by GHkrishna · Pull Request #1280 · credebl/platform · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: sign verify rawdata #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 13, 2025
Merged

feat: sign verify rawdata #1280

merged 6 commits into from
Jun 13, 2025

Conversation

GHkrishna
Copy link
Contributor
@GHkrishna GHkrishna commented Jun 13, 2025 •
edited
Loading

feat: sign verify rawdata

GHkrishna added 5 commits June 12, 2025 17:22
@GHkrishna
feat: add sign and verify api
ea360ff 
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@GHkrishna
fix: feature ids
6b9ff1e 
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@GHkrishna
fix: add validations on sign and also add validations globally to all…
00a1b49 
…ow validations to be overriden for specific DTOs

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@GHkrishna
fix: remove declarative type from enum to make it validatable
e627312 
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@GHkrishna
fix: add verification method from primary did of organization to sign…
01f87cc 
… credential payload

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Jun 13, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR tit 8000 le to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@GHkrishna
Merge branch 'develop' into feat/sign-verify-rawdata
7885261 
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@GHkrishna GHkrishna requested a review from RinkalBhojani June 13, 2025 12:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GHkrishna GHkrishna self-assigned this Jun 13, 2025
@GHkrishna GHkrishna added the enhancement New feature or request label Jun 13, 2025
@GHkrishna GHkrishna merged commit b255849 into develop Jun 13, 2025
8 checks passed
GHkrishna added a commit that referenced this pull request Jun 14, 2025
@GHkrishna
feat: sign verify rawdata (#1280)
5bb5b98 
* feat: add sign and verify api

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>

* fix: feature ids

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>

* fix: add validations on sign and also add validations globally to allow validations to be overriden for specific DTOs

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>

* fix: remove declarative type from enum to make it validatable

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>

* fix: add verification method from primary did of organization to sign credential payload

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>

---------

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RinkalBhojani RinkalBhojani RinkalBhojani approved these changes

Assignees

@GHkrishna GHkrishna

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GHkrishna @RinkalBhojani
0