8000 refactor: organization profile APIs by pranalidhanavade · Pull Request #423 · credebl/platform · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: organization profile APIs #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

pranalidhanavade
Copy link
Contributor

Refactored following APIs from organization module:

  • GET /orgs/public-profiles/{orgSlug} Fetch organization details.
  • GET /orgs/dashboard/{orgId} Get dashboard details.
  • GET /orgs/{orgId} Get an organization.

What

  • Ensured consistency of API status codes.
  • Handled error and success messages.
  • Tested with both positive and negative scenarios.

How

  • Checked and standardized API status codes to ensure a uniform response.

Why

  • Ensuring consistent API status codes improves communication between different components of the system and enhances overall reliability.

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Copy link
sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@@ -119,13 +119,6 @@ interface IOrganizationPagination {
logoUrl: string;
}

export interface IOrganizationDashboard {
usersCount: number,
schemasCount: number,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove this. Could you please tell me?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using this interface in api-gateway and organisation service, so I moved it to a common file.

Copy link
Contributor
@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@ankita-p17 ankita-p17 merged commit 267e991 into develop Jan 9, 2024
@pranalidhanavade pranalidhanavade deleted the refactor-organization-profile-api branch February 19, 2024 12:03
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
* refactor:organization dashboard api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:api summary and description

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

---------

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
* refactor:organization dashboard api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:api summary and description

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

---------

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
* refactor:organization dashboard api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:api summary and description

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

---------

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
* refactor:organization dashboard api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:api summary and description

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

---------

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
* refactor:organization dashboard api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:api summary and description

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

---------

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
* refactor:organization dashboard api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:org dashboard and get org api

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* refactor:api summary and description

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

---------

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: improve error handling for APIs of Organization Module
3 participants
0