-
Notifications
You must be signed in to change notification settings - Fork 12
Fix iterators in case we have removed an entry #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
27c5a5a
to
3eaaa1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would drop the sys.out in the tests, but otherwise lgtm.
This can typically happen while iterating and we swap elements between the head and the tail of the queue The iterator on the insertion order map is weakly consistent, but accesses to the valuemap must be checked. Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
(do not return null but throw NoSuchElementException) Track first entry in insertion order map to prevent potential race condition in pollFirstEntry Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
Updated iterators |
This comment was marked as off-topic.
This comment was marked as off-topic.
Possibly- assuming it is open source with a license compatible with ASF projects. I assume the best way to do it would be to assume that it is running as a server e.g. in a Docker container and use the API |
It is MIT, so would be okay. Would also be cool to abstract the impl in such a bolt. We could than also be able to use https://github.com/philterd/phileas (from Jeff from OpenNLP) 🫠 |
Fix iterators in case we have removed an entry
(see issue #119 )
This can typically happen while iterating and we swap elements between the head and the tail of the queue The iterator on the insertion order map is weakly consistent, but accesses to the valuemap must be checked.