10000 noxfile: mark pypy 3.11 as supported by marmoute · Pull Request #125 · crate-py/rpds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

noxfile: mark pypy 3.11 as supported #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Conversation

marmoute
Copy link
Contributor
@marmoute marmoute commented Mar 26, 2025

With pull request #123 merged, this compile with pypy3.11 fine.

This is rebased on top of #123 to have pyyp311 actually work.

Bumps [pyo3](https://github.com/pyo3/pyo3) from 0.23.4 to 0.24.0.
- [Release notes](https://github.com/pyo3/pyo3/releases)
- [Changelog](https://github.com/PyO3/pyo3/blob/main/CHANGELOG.md)
- [Commits](PyO3/pyo3@v0.23.4...v0.24.0)

---
updated-dependencies:
- dependency-name: pyo3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
With pull request crate-py#123 merged, this compile with pypy3.11 fine.
@mattip
Copy link
mattip commented Mar 26, 2025

CI is passing

@Julian
Copy link
Member
Julian commented Mar 26, 2025

Sorry, I meant to the CI build matrix's interpreters (e.g. here) so that we build wheels for it! But this is helpful too, thanks!

@Julian Julian merged commit eee5ed6 into crate-py:main Mar 26, 2025
39 checks passed
@Julian
Copy link
Member
Julian commented Mar 26, 2025

Building seems to fail still: https://github.com/crate-py/rpds/actions/runs/14083042178/job/39440334456

Help definitely still welcome @marmoute if those errors mean anything to you, otherwise I'll have to find some time to look at them more closely.

@marmoute
Copy link
Contributor Author

Building seems to fail still: https://github.com/crate-py/rpds/actions/runs/14083042178/job/39440334456

Help definitely still welcome @marmoute if those errors mean anything to you, otherwise I'll have to find some time to look at them more closely.

I am completly cluelss about these build, but double checking your patch, it seems like you have an extra comma in a space separated list pypy3.10, pypy3.11 in the first change to args: --release --out dist --interpreter.

@Julian
Copy link
Member
Julian commented Mar 26, 2025

Oh fun :/ indeed, thanks, let's see if that fixes it.

@Julian
Copy link
Member
Julian commented Mar 26, 2025

That got our errors down to one: https://github.com/crate-py/rpds/actions/runs/14084579529/job/39445373260 -- it seems the Windows build can't use PyPy3.11 even on x64, so I've re-removed it there as well. If that passes we're ready to go.

@marmoute
Copy link
Contributor Author

That got our errors down to one: https://github.com/crate-py/rpds/actions/runs/14084579529/job/39445373260 -- it seems the Windows build can't use PyPy3.11 even on x64, so I've re-removed it there as well. If that passes we're ready to go.

I don't care about Windows support here and I will let someone else take on this fight.

@mattip
Copy link
mattip commented Mar 26, 2025

That error is strange:

  --- stderr
  error: failed to generate python3.dll import library
  caused by:
    - 0: Unsupported PyPy version

What piece of the build does not support PyPy 3.11 on windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0