Change ResizeRequest to use RelationName and partition values #17098
+249
−276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c2fa54
to
e2d59e2
Compare
Relates to #16964 The request contained resolved index names which prevent us moving to using UUIDs internally. Now the request only contains the data provided in the ALTER TABLE statement (name, partition values, new number of shards)
e2d59e2
to
00c1046
Compare
mfussenegger
commented
Dec 3, 2024
| } | ||
|
|
||
| @Test | ||
| public void testPassNumRoutingShards() { |
There was a problem hiding this comment.
The request is no longer able to pass along number_of_routing_shards (and didn't do it before), so I removed the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #16964
The request contained resolved index names which prevent us moving to
using UUIDs internally.
Now the request only contains the data provided in the ALTER TABLE
statement (name, partition values, new number of shards)