Tune test suite timeout #17096
Tune test suite timeout #17096
Conversation
- Increase it to 30 minutes if triggered with jdwp (=debugger) active
- Lower it a bit for regular runs
- Increase it to 30 minutes if triggered with jdwp (=debugger) active - Lower it a bit for regular runs
4aec2e7
to
3e625ab
Compare
| public Timeout globalTimeout = ManagementFactory.getRuntimeMXBean().getInputArguments().stream() | ||
| .anyMatch(s -> s.contains("-agentlib:jdwp")) | ||
| ? new Timeout(30, TimeUnit.MINUTES) | ||
| : new Timeout(3, TimeUnit.MINUTES); |
There was a problem hiding this comment.
just curious: any reason to lower it?
There was a problem hiding this comment.
In #16964 I made some changes that led to lots of test timeouts and if each suite is stuck for 5 minutes it takes ages to get the results and see which tests are having issues.
I even lowered it to 20sec on the branch to get results within a reasonable amount of time but based on the slow test case durations on https://wacklig.pipifein.dev/github/crate/crate and accounting for slower github actions that would be too low.
I'm thinking ideally we'd set a lower default and override in test suites as needed. That would also help us get a bit more conscious about test speed (and regressions in that regard) but I didn't want to open that box right now.
There was a problem hiding this comment.
We should probably also do the same jdwp trick for the statement timeout used on execute. Avoids running into timeouts when you're too slow stepping through the code.