[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Lucene queries for AllNeqOperator #16568

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Generate Lucene queries for AllNeqOperator #16568

wants to merge 1 commit into from

Conversation

jeeminso
Copy link
Contributor
@jeeminso jeeminso commented Sep 3, 2024

Summary of the changes / Why this improves CrateDB

Checklist

  • Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
  • Updated documentation & sql_features table for user facing changes
  • Touched code is covered by tests
  • CLA is signed
  • This does not contain breaking changes, or if it does:
    • It is released within a major release
    • It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
    • It was marked as deprecated in an earlier release if possible
    • You've thought about the consequences and other components are adapted
      (E.g. AdminUI)

@jeeminso jeeminso changed the title WIP: Allen WIP: AllNeq Sep 3, 2024
@jeeminso
Copy link
Contributor Author
jeeminso commented Sep 4, 2024 •
edited
Loading

Benchmark results:

# Results (server side duration in ms)
V1: 5.9.0-dcbd23f6208c99f85aa82d287d75a8eb5955000f
V2: 5.9.0-16e1d79dc93c26ce82332f6edbcc2281fa9a6b55

Q: select count(*) from t where 1 != all(xs) -- xs: 1M rows of length 8 array of ints between 1 - 10
C: 1
| Version |         Mean ±    Stdev |        Min |     Median |         Q3 |        Max |
|   V1    |      210.037 ±  312.119 |    157.183 |    159.472 |    161.150 |   2741.040 |
|   V2    |        5.158 ±   17.223 |      2.258 |      2.803 |      3.309 |    231.683 |
├---------┴-------------------------┴------------┴------------┴------------┴------------┘
|               - 190.41%                           - 193.09%   
There is a 100.00% probability that the observed difference is not random, and the best estimate of that difference is 190.41%
The test has statistical significance

Q: select count(*) from t where 0 != all(xs)
C: 1
| Version |         Mean ±    Stdev |        Min |     Median |         Q3 |        Max |
|   V1    |      204.819 ±  285.236 |    156.095 |    158.207 |    160.772 |   2012.472 |
|   V2    |        1.605 ±    0.262 |      1.184 |      1.536 |      1.744 |      2.517 |
├---------┴-------------------------┴------------┴------------┴------------┴------------┘
|               - 196.89%                           - 196.15%   
There is a 100.00% probability that the observed difference is not random, and the best estimate of that difference is 196.89%
The test has statistical significance

@jeeminso jeeminso changed the title WIP: AllNeq Generate Lucene queries for AllNeqOperator Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeeminso