8000 Fixed Gateway API manifest by zdenekjanda · Pull Request #1016 · cozystack/cozystack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed Gateway API manifest #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Fixed Gateway API manifest #1016

merged 1 commit into from
Jun 2, 2025

Conversation

zdenekjanda
Copy link
Contributor
@zdenekjanda zdenekjanda commented Jun 2, 2025 •
edited by coderabbitai bot
Loading

In current version of Cozystack, flux's HelmRelease will refuse to install cozy-gateway-api-crds when gatewayAPI enabled, complaining version '*'not found and breaking install of entire kubernetes app. This patch adds working version match.

Summary by CodeRabbit

  • Chores
    • Updated configuration to allow compatibility with all available versions of the gateway-api-crds chart.

@zdenekjanda
Fixed Gateway API manifest
7429daf 
Signed-off-by: Zdenek Deu Janda <zdenek.janda@cloudevelops.com>
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 2, 2025 •
edited
Loading

Walkthrough

A version constraint was added to the HelmRelease manifest for the gateway-api-crds chart, specifying that any chart version greater than or equal to 0.0.0-0 should be used. No other changes were made to logic, error handling, or control flow.

Changes

File(s) Change Summary
packages/apps/kubernetes/templates/helmreleases/gateway-api-crds.yaml Added version constraint to HelmRepository source reference

Poem

In the garden of YAML, a line did appear,
A version constraint now makes intentions clear.
From zero and up, the charts may flow,
Gateway CRDs ready, onward we go!
🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 2, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/apps/kubernetes/templates/helmreleases/gateway-api-crds.yaml (1)

20-20: Add version constraint to resolve installation failure
The new line

version: '>= 0.0.0-0'

ensures Flux will match any published chart version, fixing the “version '*' not found” error when gatewayAPI is enabled.

Consider tightening this to a known stable range (for example, >=1.0.0 <2.0.0) to avoid unintended upgrades.
Please verify that your HelmRepository actually contains versions satisfying this constraint by checking available chart versions in the cozystack-system repo.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b470b82 and 7429daf.

📒 Files selected for processing (1)
  • packages/apps/kubernetes/templates/helmreleases/gateway-api-crds.yaml (1 hunks)

kvaps
kvaps approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member
@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvaps kvaps merged commit 92b97a5 into cozystack:main Jun 2, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@kvaps kvaps kvaps approved these changes

@lllamnyp lllamnyp Awaiting requested review from lllamnyp lllamnyp is a code owner

@klinch0 klinch0 Awaiting requested review from klinch0 klinch0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdenekjanda @kvaps
0