8000 [docs] Update release policy: Release Candidate versions by NickVolynkin · Pull Request #897 · cozystack/cozystack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[docs] Update release policy: Release Candidate versions #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

NickVolynkin
Copy link
Collaborator
@NickVolynkin NickVolynkin commented Apr 25, 2025

Summary by CodeRabbit

  • Documentation
    • Expanded the release documentation with a new section explaining Cozystack's staged release process, including details on Release Candidates, Regular Releases, and Patch Releases.
    • Clarified the workflow and purpose of Release Candidates and updated the explanation of how regular releases are created.
  • Chores
    • Updated the pre-commit workflow to run checks on all pull request events, including those with only documentation changes.

Copy link
Contributor
coderabbitai bot commented Apr 25, 2025

Walkthrough

The release documentation was updated to include a new introductory section that explains Cozystack's staged release process. This addition describes the three types of releases—Release Candidates, Regular Releases, and Patch Releases—clarifying the workflow and the relationship between these stages. The section on Regular Releases was also revised to specify that the release commit is taken from the latest Release Candidate or a subsequent minimal-change commit. Additionally, the GitHub Actions pre-commit workflow was modified by removing the paths-ignore filter that excluded Markdown files from triggering the workflow on pull requests, causing the workflow to now run on all pull requests including those with only Markdown changes. No changes were made to code or exported entities.

Changes

File(s) Change Summary
docs/release.md Added an introductory section on the staged release process, clarified release types and workflow, updated Regular Releases explanation.
.github/workflows/pre-commit.yml Removed paths-ignore filter for Markdown files, so pre-commit workflow now triggers on all pull requests including Markdown-only changes.

Possibly related PRs

Suggested reviewers

  • lllamnyp
  • kvaps

Poem

In the meadow of docs where the details grow,
A new section sprouts, release wisdom to show.
RCs hop in first, with features to test,
Regulars and patches then follow the rest.
With clarity added, our process is bright,
The release path is clear—what a wonderful sight!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 12c6df8 and 70fed81.

📒 Files selected for processing (1)
  • .github/workflows/pre-commit.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/pre-commit.yml
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (6)
docs/release.md (6)

3-4: Refine document introduction phrasing
The current sentence is a bit wordy and passive. Consider replacing it with a more direct description of the process.

- This document explains how Cozystack builds and releases are made.
+ This document describes Cozystack’s build and release process.

5-6: Use a full-word heading for clarity
“Intro” is informal—prefer “Introduction” to match common documentation conventions.

- ## Intro
+ ## Introduction

7-8: Remove trailing spaces for Markdown consistency
Line 7 ends with two spaces to force a break. It’s better to use a blank line or a <br/> tag explicitly if a line break is needed, or simply rely on paragraph separation.

- Cozystack uses a staged release process to ensure stability and flexibility during development.  
+ Cozystack uses a staged release process to ensure stability and flexibility during development.

11-13: Unify pre-release version formatting
You show two different RC formats: v0.42.0-rc.1 in the list but v0.42.0-rc1 in the example. Choose one approach—e.g., SemVer–compliant -rc.1—and apply it consistently across the document.

Also applies to: 23-23


28-28: Fix extra space inside code span
Remove the unintended space before the closing backtick to satisfy Markdown lint rule MD038.

- Each RC contributes to a cumulative set of release notes that will be finalized when `vX.Y.0 `is released.
+ Each RC contributes to a cumulative set of release notes that will be finalized when `vX.Y.0` is released.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

28-28: Spaces inside code span elements
null

(MD038, no-space-in-code)


34-34: Clarify Regular Releases sentence
The phrasing “take… and decide to make it a release” is a bit awkward. Consider tightening it for clarity.

- When making regular releases, we take the latest release candidate version or a subsequent commit with minimal changes, and decide to make it a release `vX.Y.0`.
+ When making a regular release, we tag the latest RC or a subsequent minimal-change commit as `vX.Y.0`.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa341de and b87196d.

📒 Files selected for processing (1)
  • docs/release.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/release.md

28-28: Spaces inside code span elements
null

(MD038, no-space-in-code)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test

@NickVolynkin NickVolynkin force-pushed the update-release-policy branch from b87196d to e9aca2d Compare April 25, 2025 13:03
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
docs/release.md (3)

3-4: Refine introductory statement for clarity.
The current phrasing “how Cozystack builds and releases are made” reads a bit awkwardly. Consider rewording to something like:

This document describes Cozystack’s build and release workflows.

This is more direct and aligns with common documentation style.


5-6: Use a standard “Introduction” heading.
To maintain consistency with typical docs, rename the section title from:

## Intro

to:

## Introduction

34-34: Rephrase the regular release sentence for conciseness.
The clause “and decide to make it a release” is verbose. You could rewrite this line as:

When making regular releases, we use the latest release candidate or a subsequent minimal-change commit as the `vX.Y.0` tag.

This version is shorter and clearer.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b87196d and e9aca2d.

📒 Files selected for processing (1)
  • docs/release.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/release.md

28-28: Spaces inside code span elements
null

(MD038, no-space-in-code)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test

@NickVolynkin NickVolynkin force-pushed the update-release-policy branch 2 times, most recently from aa78b88 to 77eb5b8 Compare April 29, 2025 08:31
@NickVolynkin NickVolynkin requested a review from kvaps April 29, 2025 08:31
@NickVolynkin NickVolynkin force-pushed the update-release-policy branch from 77eb5b8 to 7ab2652 Compare April 29, 2025 08:33
@NickVolynkin NickVolynkin enabled auto-merge April 29, 2025 09:30
Copy link
Member
@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NickVolynkin NickVolynkin disabled auto-merge May 5, 2025 08:51
Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
@NickVolynkin NickVolynkin force-pushed the update-release-policy branch from 7ab2652 to 12c6df8 Compare May 5, 2025 08:52
Pre-commit is now required to merge PRs, so let it run even on documentation updates.
An alternative is to merge with administrator permissions, bypassing rules,
which is not a good practice.

Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
@NickVolynkin NickVolynkin enabled auto-merge May 5, 2025 08:59
@NickVolynkin NickVolynkin merged commit 062d728 into main May 5, 2025
6 checks passed
@NickVolynkin NickVolynkin deleted the update-release-policy branch May 5, 2025 09:15
lllamnyp pushed a commit that referenced this pull request May 20, 2025
*Documentation**
- Expanded the release documentation with a new section explaining
Cozystack's staged release process, including details on Release
Candidates, Regular Releases, and Patch Releases.
- Clarified the workflow and purpose of Release Candidates and updated
the explanation of how regular rele
8000
ases are created.

Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
(cherry picked from commit 062d728)
Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
@lllamnyp lllamnyp mentioned this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0