[ci] automatically trigger tests in releasing PR #894
Conversation
|
Warning Rate limit exceeded@kvaps has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 32 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThis update introduces the ability to manually trigger the Changes
Sequence Diagram(s)sequenceDiagram
participant TagWorkflow as tags.yaml
participant GHAPI as GitHub Actions API
participant PRReleaseWorkflow as pull-requests-release.yaml
TagWorkflow->>GHAPI: Trigger workflow_dispatch (with sha input)
GHAPI->>PRReleaseWorkflow: Start workflow (using provided sha)
PRReleaseWorkflow->>PRReleaseWorkflow: Run verify job on specified commit
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/tags.yaml (1)
231-233: Refine YAML key spacing.YAMLlint reports “too many spaces after colon” on these mappings. Normalize to a single space after each colon to satisfy lint rules:
- GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - DISPATCH_REF: ${{ steps.get_base.outputs.branch }} - DISPATCH_SHA: ${{ github.sha }} + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + DISPATCH_REF: ${{ steps.get_base.outputs.branch }} + DISPATCH_SHA: ${{ github.sha }}🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 231-231: too many spaces after colon
(colons)
[warning] 232-232: too many spaces after colon
(colons)
[warning] 233-233: too many spaces after colon
(colons)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/pull-requests-release.yaml(2 hunks).github/workflows/tags.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/tags.yaml
[warning] 231-231: too many spaces after colon
(colons)
[warning] 232-232: too many spaces after colon
(colons)
[warning] 233-233: too many spaces after colon
(colons)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build and Test
🔇 Additional comments (4)
.github/workflows/tags.yaml (1)
226-247: Automate dispatch of verify tests on new release tags.This step correctly invokes the
pull-requests-release.yamlworkflow via a dispatch event on the target branch (DISPATCH_REF), passing the commit SHA (DISPATCH_SHA) to run the verification tests on the release commit. It integrates neatly with the existing tagging flow to ensure tests are run after a tag is published.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 231-231: too many spaces after colon
(colons)
[warning] 232-232: too many spaces after colon
(colons)
[warning] 233-233: too many spaces after colon
(colons)
.github/workflows/pull-requests-release.yaml (3)
6-11: Enable manual triggering withworkflow_dispatch.Adding
workflow_dispatchwith a requiredshainput allows ad-hoc invocation of the release tests on any commit SHA. This complements the PR-label trigger and gives maintainers the flexibility to re-run or debug tests outside of PR events.
24-30: Combine PR label and manual dispatch conditions.The updated
ifexpression correctly gates theverifyjob to run when the PR is labeledrelease(and not closed) or when invoked viaworkflow_dispatch. This ensures coverage in both scenarios.
35-37: Checkout specific SHA based on trigger.The boolean expression selects
pull_request.head.shafor labeled PRs or falls back toinputs.shafor manual dispatch, ensuring the correct commit is checked out in both workflows.
| workflow_dispatch: | ||
| inputs: | ||
| sha: | ||
| description: "Commit SHA to test" | ||
| required: true | ||
|
|
There was a problem hiding this comment.
Concurrency group may break for manual triggers.
The existing concurrency group uses github.event.pull_request.number, which is undefined for workflow_dispatch events and could lead to errors or unintended queuing.
Consider a fallback for dispatch triggers, for example:
-concurrency:
- group: pull-requests-release-${{ github.workflow }}-${{ github.event.pull_request.number }}
+concurrency:
+ group: pull-requests-release-${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: trueCommittable suggestion skipped: line range outside the PR's diff.
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Revert #894 due to fact this logic does not trigger checks in pull requests <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Removed support for manually triggering the pull request release workflow. - Simplified release workflow to run automatically only on labeled pull requests. - Eliminated the step in the tags workflow that triggered release verification via manual dispatch. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Revert #894 due to fact this logic does not trigger checks in pull requests <!-- This is 7D2A an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Removed support for manually triggering the pull request release workflow. - Simplified release workflow to run automatically only on labeled pull requests. - Eliminated the step in the tags workflow that triggered release verification via manual dispatch. <!-- end of auto-generated comment: release notes by coderabbit.ai --> (cherry picked from commit e1c1461) Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
Signed-off-by: Andrei Kvapil kvapss@gmail.com
Summary by CodeRabbit