8000 fix: handle timeout issues in splashscreen (VO-231) by acezard · Pull Request #1162 · cozy/cozy-flagship-app · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: handle timeout issues in splashscreen (VO-231) #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree 8000 to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix: handle timeout issues in splashscreen (VO-231) #1162

merged 2 commits into from
Feb 9, 2024

Conversation

acezard
Copy link
Contributor
@acezard acezard commented Feb 7, 2024 •
edited
Loading

This fix introduces several changes in splashscreen failsafe management:

  • More logging
  • Initial timer on "global" to handle scenarios where no showSplashScreen() are called
  • Use a map to allow multiple timers coexisting
  • On background handling (delete every timer)
  • On active handling (reset timers that existed before going to background to the timeout value, this will allow us to ignore all problems related to unreliable timeout in background mode, remember that these timeout should not be needed in normal circumstances)

Examples

Normal flow:
image

Going from active to background to active
image

On this one I had a bug (linked to hot reloading so can't say exactly what happened), but we can still see the timeout managed the issue in the end
image

@acezard acezard force-pushed the fix--handle-timeout-issues-in-splashscreen branch 3 times, most recently from ffab59b to fdb1023 Compare February 8, 2024 14:10
@acezard acezard changed the title fix: handle timeout issues in splashscreen fix: handle timeout issues in splashscreen (VO-231) Feb 8, 2024
@acezard acezard marked this pull request as ready for review February 8, 2024 14:10
@acezard
fix: handle timeout issues in splashscreen
33843de 
Improve timeout management and add initial global timeout
@acezard acezard force-pushed the fix--handle-timeout-issues-in-splashscreen branch from fdb1023 to 33843de Compare February 8, 2024 14:17
Ldoppea
Ldoppea approved these changes Feb 9, 2024
View reviewed changes
@acezard acezard force-pushed the fix--handle-timeout-issues-in-splashscreen branch from f9fb2eb to 137135e Compare February 9, 2024 13:52
@acezard acezard merged commit 4b7b129 into master Feb 9, 2024
@acezard acezard deleted the fix--handle-timeout-issues-in-splashscreen branch February 9, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ldoppea Ldoppea Ldoppea approved these changes

@zatteo zatteo zatteo approved these changes

Assignees

@Ldoppea Ldoppea

@zatteo zatteo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acezard @Ldoppea @zatteo
0