fix: handle some dimensions race conditions (VO-264) #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can fix race conditions where the height is 0. In practice, it's not supposed to ever be under 24
5ae219e to
1a0d0df
Compare
zatteo
approved these changes
Jan 31, 2024
|
nit: First commit start with |
|
edit: Just read the issue on Linear. Understood. |
This will avoid the function being called at import time Meaning it should now always be called at function/component runtime, so the race conditions where getDimensions is called before the dimensions are computed by the native lib are removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will use the hook return values if possible, otherwise use 24px as default height on Android.
This will remove cases where the dimensions were wrongfully set at the start of the app to be 0, resulting in overlap in statusbar and application
This PR also ensures all getDimensions() call that were at the module level are now moved into the application lifecycle