8000 feat: add new non-native Modal component by acezard · Pull Request #1066 · cozy/cozy-flagship-app · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ cozy-flagship-app Public

feat: add new non-native Modal component #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 14, 2023
Merged

feat: add new non-native Modal component #1066

merged 4 commits into from
Dec 14, 2023

Conversation

acezard
Copy link
Contributor
@acezard acezard commented Dec 13, 2023 •
edited
Loading

This is needed on screens where we do not have agency in what is displayed on top of the screen. While it may be tempting to use it everywhere for consistency, I believe it's better to rely on the react-native Modal component when possible. This should be used as a last resort where FullWindowOverlay for instance disallow us to display anything above it (on the native UI side).

@acezard acezard changed the title temp commit feat: add new non-native Modal component Dec 13, 2023
@acezard acezard force-pushed the feat--add-non-native-modal branch from f9d0e21 to 4361a99 Compare December 13, 2023 13:54
@acezard acezard force-pushed the feat--add-non-native-modal branch from 4361a99 to 703995f Compare December 13, 2023 13:56
@acezard
feat: use non-native modal where needed
1dba59d 
Here we target screens in FullWindowOverlay;
The native modal can't be seen as it's below the app on the OS level
Also removing FullWindowOverlay in SetPinView.
The reasoning is that it was added by mistake. There is no need
for this screen to force that hard to render on top of everything
@acezard acezard force-pushed the feat--add-non-native-modal branch from 703995f to 1dba59d Compare December 13, 2023 13:58
@acezard acezard marked this pull request as ready for review December 13, 2023 13:59
Ldoppea
Ldoppea reviewed Dec 14, 2023
View reviewed changes
@acezard
refactor: ConfirmDialog and LockScreen components
266d4e2 
- Update typings, default values
- Update theming
@acezard acezard force-pushed the feat--add-non-native-modal branch from cf1b0d8 to 266d4e2 Compare December 14, 2023 13:30
@acezard acezard requested a review from Ldoppea December 14, 2023 13:30
@acezard acezard merged commit 9b8ff01 into master Dec 14, 2023
@acezard acezard deleted the feat--add-non-native-modal branch December 14, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ldoppea Ldoppea Ldoppea approved these changes

@zatteo zatteo Awaiting requested review from zatteo zatteo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acezard @Ldoppea
0