8000 fix: downgrade react-native 0.65.x to 0.63.x by pm-McFly · Pull Request #1608 · cozy/cozy-client · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: downgrade react-native 0.65.x to 0.63.x #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pm-McFly
Copy link

react-native 0.65.x is compatible w/ react 17 only

@pm-McFly pm-McFly requested a review from paultranvan as a code owner May 11, 2025 08:46
  react-native 0.65.x is compatible w/ react 17 only
@zatteo
Copy link
Member
zatteo commented May 12, 2025

Interesting because in practice we are on react-native 0.73. So even if it is more correct from a dependency point of view to downgrade it does not make really sense. It must be because we use a very small subset of React Native that we did not encounter issues.

Counter proposition 1 : update our apps to React 17

Counter proposition 2 : remove dependency to React Native in cozy-client. I was never comfortable with this dependency. Is there a way to inject the methods relying on React Native in the apps instead of having them here ?

@Ldoppea
Copy link
Member
Ldoppea commented May 12, 2025

@pm-McFly did you encounter an issue with this? Or is this "by principle"?

In cozy-client, the react-native dependency is used only in .native.js files and those files are loaded only in our react-native app, it is never loaded in a web environment.

More specifically this is used in authentication/mobile.native.js. This specific part does not use any React related mechanism, so we should never encounter any incompatibility between the cozy-client's react version and its react-native version.

@pm-McFly
Copy link
Author
pm-McFly commented May 12, 2025

@pm-McFly did you encounter an issue with this? Or is this "by principle"?

No don't worry I won't open a discussion about which version should be used when or NPM/YARN debate 😉

It's mostly about the fact that I wanted to try-out cozy-ui and got stuck during dependency resolving (cf. linked issue comment with full details)

This specific part does not use any React related mechanism, so we should never encounter any incompatibility between the cozy-client's react version and its react-native version.

Unfortunately this is not understood by the NPM/YARN deps resolution system:
cozy/cozy-ui#2789 (comment)

Thx for enlightening the purpose of the use of react and react native as peer, btw!

@pm-McFly pm-McFly marked this pull request as draft May 12, 2025 10:49
@pm-McFly
Copy link
Author

btw after some trials... React version is incorrect..
need more in-depth analysis to figure out the correct one!

@pm-McFly
Copy link
Author
pm-McFly commented May 13, 2025

revert to only downgrade rn version to 0.63.5 (expecting react 16.13.1) -> need to verify other repos for react compat!

dep verified
cozy-client
cozy-device-helper ok
cozy-flags ok
cozy-intent ok
cozy-logger ok
cozy-stack-client ok
cozy-ui ok

@pm-McFly pm-McFly marked this pull request as ready for review May 13, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0