-
Notifications
You must be signed in to change notification settings - Fork 14
fix: downgrade react-native 0.65.x to 0.63.x #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
react-native 0.65.x is compatible w/ react 17 only
Interesting because in practice we are on react-native 0.73. So even if it is more correct from a dependency point of view to downgrade it does not make really sense. It must be because we use a very small subset of React Native that we did not encounter issues. Counter proposition 1 : update our apps to React 17 Counter proposition 2 : remove dependency to React Native in cozy-client. I was never comfortable with this dependency. Is there a way to inject the methods relying on React Native in the apps instead of having them here ? |
@pm-McFly did you encounter an issue with this? Or is this "by principle"? In cozy-client, the react-native dependency is used only in More specifically this is used in |
No don't worry I won't open a discussion about which version should be used when or NPM/YARN debate 😉 It's mostly about the fact that I wanted to try-out cozy-ui and got stuck during dependency resolving (cf. linked issue comment with full details)
Unfortunately this is not understood by the NPM/YARN deps resolution system: Thx for enlightening the purpose of the use of react and react native as peer, btw! |
btw after some trials... React version is incorrect.. |
revert to only downgrade rn version to 0.63.5 (expecting react 16.13.1) -> need to verify other repos for react compat!
|
react-native 0.65.x is compatible w/ react 17 only