feat: Inform when dataproxy is ready #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parent apps need a way to knwo when the DataProxy is ready to be requested. Otherwise, errors could occur because the init is not done.
Ldoppea
approved these changes
May 13, 2025
Comment on lines
+33
to
+40
| const sendReadyMessage = (): void => { | ||
| // This is useful to inform the parent apps that the DataProxy's iframe is ready to be requested | ||
| window.parent.postMessage( | ||
| { type: 'DATAPROXYMESSAGE', payload: 'READY' }, | ||
| '*' | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: this can be easily moved outside of the react component for better readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent apps need a way to knwo when the DataProxy is ready to be requested.
Otherwise, errors could occur because the init is not done.