8000 fix: change french name of France subdivisions by Bertrand-Bichat · Pull Request #919 · countries/countries · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: change french name of France subdivisions #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

fix: change french name of France subdivisions #919

merged 1 commit into from
Jun 25, 2025

Conversation

Bertrand-Bichat
Copy link
Contributor
@Bertrand-Bichat Bertrand-Bichat commented Jun 12, 2025 •
edited
Loading

In file lib/countries/data/subdivisions/FR.yaml :

  • use French name Nouvelle-Calédonie for New Caledonia as subdivision of France country

In file lib/countries/data/translations/countries-fr.yaml :

  • add CP: Clipperton because there is also TF: Terres australes françaises in the same file

@Bertrand-Bichat Bertrand-Bichat changed the title change french name of France subdivisions fix: change french name of France subdivisions Jun 12, 2025
@Bertrand-Bichat
Copy link
Contributor Author

Hi @pmor, can you tell me if my PR is OK for you or not, please ?

@pmor
Copy link
Member
pmor commented Jun 18, 2025

Hi @Bertrand-Bichat ,

Thanks for the PR!

We follow ISO naming as much as possible, and the name changes you have here do not match ISO data from https://www.iso.org/obp/ui/#iso:code:3166:FR , so I'll gladly accept the new translations, but I'll ask you to revert the changes to the name attributes, so that we keep the ISO data there.

@Bertrand-Bichat
Copy link
Contributor Author

Hi @Bertrand-Bichat ,

Thanks for the PR!

We follow ISO naming as much as possible, and the name changes you have here do not match ISO data from https://www.iso.org/obp/ui/#iso:code:3166:FR , so I'll gladly accept the new translations, but I'll ask you to revert the changes to the name attributes, so that we keep the ISO data there.

@pmor ok, I have modified my commit to only change the New Caledonia French subdivision name attribute.
Is that correct for you ?

@Bertrand-Bichat
Copy link
Contributor Author

@pmor can you tell me if my pull request is correct for you, please ?

@pmor pmor merged commit 0e2c8bb into countries:master Jun 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bertrand-Bichat @pmor
0