redis: use dbname param when redis is unauthenticated #1668
Conversation
8ff8ec8 to
499a00e
Compare
|
Hi @maddymeows ! Thanks for the PR |
|
A regression was introduced in the last PR where the dbname parameter was not respected if using redis without authentication. The logic for sending the select command responsible for switching to the correct database was wrongly guarded behind authentication being provided. This PR flattens the control flow so the select command is always sent, whether using authentication or not. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Redis connection setup to ensure the co->dbname parameter is applied even when no authentication is used, addressing a regression.
- Separated the error, authentication, and database selection into independent checks
- Always executes the
SELECTcommand whenco->dbnameis set, regardless of authentication state
Comments suppressed due to low confidence (1)
src/apps/relay/dbdrivers/dbd_redis.c:374
- Consider adding or updating tests to cover the new unauthenticated DB selection logic, ensuring that the
co->dbnamebranch is exercised when no password is provided.
if (redisconnection && co->dbname) {
|
thank you for this PR @maddymeows 🙇 |
Fixes a regression pointed out at #1488 (comment).
A regression was introduced in the last PR where the dbname parameter was not respected if using redis without authentication. The logic for sending the select command responsible for switching to the correct database was wrongly guarded behind authentication being provided. This PR flattens the control flow so the select command is always sent, whether using authentication or not.