8000 chore: update CI node version to `lts/jod` by cowdan · Pull Request #287 · cowprotocol/cow-sdk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: update CI node version to lts/jod #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

chore: update CI node version to lts/jod #287

merged 1 commit into from
Apr 22, 2025

Conversation

cowdan
Copy link
Contributor
@cowdan cowdan commented Apr 15, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated the Node.js version used in build, test, and publish workflows to ensure compatibility with the latest Node.js LTS release.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 15, 2025 •
edited
Loading

Walkthrough

The updates modify the Node.js version used in the GitHub Actions workflows for building, testing, and publishing the project. Specifically, the environment variable specifying the Node.js version was changed from lts/hydrogen to lts/jod in the respective YAML configuration files. No other workflow logic, steps, or control flow were altered.

Changes

File(s) Change Summary
.github/workflows/build.yml Updated NODE_VERSION from lts/hydrogen to lts/jod.
.github/workflows/publish.yml Updated Node.js version from lts/hydrogen to lts/jod.
.github/workflows/test.yml Updated NODE_VERSION from lts/hydrogen to lts/jod.

Poem

A hop, a skip, a Node.js leap,
From Hydrogen to Jod we sweep!
Workflows fresh, the build anew,
Tests and publish hopping through.
In YAML fields our changes grow—
The garden’s ready, let’s ship and go!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b0f9ca and b67723c.

📒 Files selected for processing (3)
  • .github/workflows/build.yml (1 hunks)
  • .github/workflows/publish.yml (1 hunks)
  • .github/workflows/test.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Build Package
  • GitHub Check: test
🔇 Additional comments (3)
.github/workflows/publish.yml (1)

8-8:

✅ Verification successful

Confirm lts/jod is a valid Node.js LTS identifier.

The update is correct and maintains consistency across workflows. Please verify that lts/jod is a valid and supported Node.js LTS version identifier for actions/setup-node, as Node.js LTS codenames change over time.

If you want to automate this check, you can run:

🏁 Script executed:

#!/bin/bash
# List all available Node.js LTS versions recognized by setup-node
curl -s https://nodejs.org/dist/index.json | jq '.[].lts' | sort | uniq

Length of output: 167

LTS Identifier 'lts/jod' Verified

After running the suggested script, the Node.js distribution listing shows "Jod" among the available LTS identifiers. This confirms that using lts/jod in the workflow is valid. The update maintains consistency across workflows, and no further changes are necessary.

.github/workflows/test.yml (1)

5-5: Ensure lts/jod is a valid Node.js LTS version.

This change is correct and keeps the workflows consistent. Please confirm that lts/jod is a valid Node.js LTS identifier for use with actions/setup-node.

You can use the same script as above to check available LTS identifiers.

.github/workflows/build.yml (1)

16-16: Verify lts/jod is a valid Node.js LTS codename.

This update is correct and ensures all workflows use the same Node.js version. Please confirm that lts/jod is a valid and supported LTS identifier for actions/setup-node.

Refer to the script in the previous comments to check available LTS codenames.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 15, 2025 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@coveralls
Copy link
Collaborator
coveralls commented Apr 15, 2025 •
edited
Loading

Coverage Status

coverage: 78.013%. remained the same
when pulling b67723c on feat/update-node-version
into 9b0f9ca on main.

@cowdan cowdan requested a review from a team April 15, 2025 15:29
@alfetopito
Copy link
Contributor
alfetopito commented Apr 15, 2025 •
edited
Loading

@cowdan can you sign the CLA?

#287 (comment)

@cowdan
Copy link
Contributor Author
cowdan commented Apr 15, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Apr 15, 2025
@github-actions
@cowdan has signed the CLA from Pull Request #287
5c3f462
@cowdan
Copy link
Contributor Author
cowdan commented Apr 15, 2025

recheck

@cowdan cowdan merged commit b75675c into main Apr 22, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2025
@alfetopito alfetopito deleted the feat/update-node-version branch April 22, 2025 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@shoom3301 shoom3301 shoom3301 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cowdan @coveralls @alfetopito @shoom3301
0