8000 feat(bridge): display execution price in swap details by shoom3301 · Pull Request #5920 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(bridge): display execution price in swap details #5920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(bridge): display execution price in swap details #5920

wants to merge 2 commits into from

Conversation

shoom3301
Copy link
Collaborator
@shoom3301 shoom3301 commented Jul 3, 2025 •
edited by coderabbitai bot
Loading

Summary

Fixes https://www.notion.so/cownation/Account-modal-No-Execution-price-on-the-Swap-order-details-21e8da5f04ca80c29405d10385e4fa1e?source=copy_link

image

To Test

  1. Exec. price should be displayed in activities list for briding orders
  2. Exec. price should be displayed in progress modal when swap is executed

Summary by CodeRabbit

  • New Features

    • Swap result details now include execution price information for greater transparency.
    • Enhanced display of received amounts, solver details, and surplus in swap result summaries.

  • Refactor

    • Improved internal structure for generating and displaying swap result details, ensuring a more consistent and maintainable user experience.

@shoom3301 shoom3301 self-assigned this Jul 3, 2025
@vercel Vercel
Copy link
vercel bot commented Jul 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cowfi ✅ Ready (Inspect) Visit Preview Jul 3, 2025 11:52am
explorer-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2025 11:52am
swap-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2025 11:52am
3 Skipped Deployments
Name Status Preview Updated (UTC)
cosmos ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2025 11:52am
sdk-tools ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2025 11:52am
widget-configurator ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2025 11:52am

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 3, 2025 •
edited
Loading

Walkthrough

This change refactors the SwapResultContent component to accept a new sellAmount prop and moves content generation logic into external helper functions. The SwapStepRow and ProgressDetails components are updated to pass the new prop. A new module provides helper functions for constructing swap result content blocks.

Changes

File(s) Change Summary
.../BridgeActivitySummary/SwapStepRow.tsx
.../ProgressDetails/index.tsx		 Updated to pass sellAmount prop to SwapResultContent.
.../contents/SwapResultContent/contents.tsx New module: Adds helper functions for generating swap result content blocks.
.../contents/SwapResultContent/index.tsx Refactored to use new helper functions for content generation and added sellAmount prop to component.
.../account/containers/Transaction/ActivityDetails.tsx Changed boolean prop noLabel={true} to shorthand noLabel in RateInfo component usage.

Sequence Diagram(s)

sequenceDiagram
    participant SwapStepRow
    participant ProgressDetails
    participant SwapResultContent
    participant ContentsHelpers

    SwapStepRow->>SwapResultContent: Render with context, sellAmount
    ProgressDetails->>SwapResultContent: Render with context, sellAmount
    SwapResultContent->>ContentsHelpers: getSolverContent(...)
    SwapResultContent->>ContentsHelpers: getReceivedContent(...)
    SwapResultContent->>ContentsHelpers: getExecPriceContent(sellAmount, ...)
    SwapResultContent->>ContentsHelpers: getSurplusConfig(...)
    ContentsHelpers-->>SwapResultContent: ContentConfig objects
    SwapResultContent-->>SwapStepRow: Rendered content
    SwapResultContent-->>ProgressDetails: Rendered content
Loading

Suggested reviewers

  • elena-zh

Poem

In the meadow of code, a swap hops anew,
With helper friends to guide what the numbers do.
SellAmount in paw, content blocks align,
The bridge is more clever, the summary divine.
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
(node:19906) [DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.
(Use node --trace-deprecation ... to show where the warning was created)
[2/4] Fetching packages...
error nx@21.0.3: The engine "node" is incompatible with this module. Expected version "^20.19.0 || ^22.12.0". Got "24.3.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e750863 and 4912f48.

📒 Files selected for processing (3)
  • apps/cowswap-frontend/src/modules/account/containers/Transaction/ActivityDetails.tsx (1 hunks)
  • apps/cowswap-frontend/src/modules/bridge/pure/contents/SwapResultContent/contents.tsx (1 hunks)
  • apps/cowswap-frontend/src/modules/bridge/pure/contents/SwapResultContent/index.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/cowswap-frontend/src/modules/account/containers/Transaction/ActivityDetails.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/cowswap-frontend/src/modules/bridge/pure/contents/SwapResultContent/index.tsx
  • apps/cowswap-frontend/src/modules/bridge/pure/contents/SwapResultContent/contents.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Lint
  • GitHub Check: Test
  • GitHub Check: Cypress
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shoom3301 shoom3301 requested review from a team July 3, 2025 07:33
@shoom3301 shoom3301 marked this pull request as ready for review July 3, 2025 07:34
elena-zh
elena-zh reviewed Jul 3, 2025
View reviewed changes
Copy link
Contributor
@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shoom3301 , cool, great!
However, 2 nitpicks:

  1. It would be great to add a space between 1 and a token symbol on Bridge modals
    space
  2. In the account modal the price should be inverted (see the comparison with the regular order):
    Screenshot_1

Could you please fix it?

@shoom3301
Copy link
Collaborator Author

Thanks @elena-zh, fixed!

@shoom3301
Copy link
Collaborator Author

@coderabbitai review

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 3, 2025
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@elena-zh
Copy link
Contributor
elena-zh commented Jul 3, 2025

Great! The last nitpick is:

  1. on Bridging screens
  2. When I press on the invert price the 1st time
  3. it auto-reverts the price back in 5 seconds or sometimes blinks with revert back action
    Could you please check why it is happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elena-zh elena-zh elena-zh left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@shoom3301 shoom3301

Labels
Bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoom3301 @elena-zh
0