8000 fix(bridge): load networks info in all trade widgets by shoom3301 · Pull Request #5925 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(bridge): load networks info in all trade widgets #5925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

fix(bridge): load networks info in all trade widgets #5925

merged 1 commit into from
Jul 4, 2025
+3 −8

Conversation

shoom3301
Copy link
Collaborator
@shoom3301 shoom3301 commented Jul 3, 2025 •
edited by coderabbitai bot
Loading

Summary

Fixes https://www.notion.so/cownation/Swap-details-are-not-loaded-when-open-Account-modal-from-limit-twap-hooks-tab-2248da5f04ca8052bfd2ef86df3d17eb?source=copy_link

useIsBridgingEnabled() returns true only in Swap widget, but account modal can be opened in any page.
To fix that I removed isBridgingEnabled condition from useBridgeSupportedNetworks.

To Test

See https://www.notion.so/cownation/Swap-details-are-not-loaded-when-open-Account-modal-from-limit-twap-hooks-tab-2248da5f04ca8052bfd2ef86df3d17eb?source=copy_link

Summary by CodeRabbit

  • Refactor
    • Improved the behavior of network support fetching for bridging by always retrieving supported networks, regardless of bridging status.

@shoom3301 shoom3301 self-assigned this Jul 3, 2025
@vercel Vercel
Copy link
vercel bot commented Jul 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ❌ Failed (Inspect) Jul 3, 2025 11:48am
cowfi ✅ Ready (Inspect) Visit Preview Jul 3, 2025 11:48am
explorer-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2025 11:48am
sdk-tools ✅ Ready (Inspect) Visit Preview Jul 3, 2025 11:48am
swap-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2025 11:48am
widget-configurator ✅ Ready (Inspect) Visit Preview Jul 3, 2025 11:48am

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 3, 2025 •
edited
Loading

Walkthrough

The useBridgeSupportedNetworks hook was updated to always fetch supported networks from the bridge provider, regardless of whether bridging is enabled. The conditional check and related imports for bridging enablement were removed, and the SWR fetch key is now always set based on the bridge provider.

Changes

File(s) Change Summary
apps/cowswap-frontend/src/entities/bridgeProvider/useBridgeSupportedNetworks.ts Removed conditional check for bridging enablement; always fetches supported networks; cleaned up imports.

Sequence Diagram(s)

sequenceDiagram
  participant Component
  participant useBridgeSupportedNetworks
  participant bridgeProvider

  Component->>useBridgeSupportedNetworks: Call hook with bridgeProvider
  useBridgeSupportedNetworks->>bridgeProvider: getNetworks()
  bridgeProvider-->>useBridgeSupportedNetworks: Supported networks data
  useBridgeSupportedNetworks-->>Component: Return networks data
Loading

Possibly related PRs

  • cowprotocol/cowswap#5865: Modifies usage of useBridgeSupportedNetworks to customize explorer links, directly affected by this hook's behavior.
  • cowprotocol/cowswap#5837: Introduces and manages bridging enablement state, previously affecting the same hook's conditional logic.

Suggested reviewers

  • elena-zh
  • alfetopito

Poem

A hop and a skip, no more delay,
Bridge networks fetched, come what may!
No checks or toggles, just data in tow,
Networks arrive, as swift as a doe.
Rabbits approve—let the bridges flow! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
(node:17483) [DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.
(Use node --trace-deprecation ... to show where the warning was created)
[2/4] Fetching packages...
error nx@21.0.3: The engine "node" is incompatible with this module. Expected version "^20.19.0 || ^22.12.0". Got "24.3.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d4390bb and a2ec084.

📒 Files selected for processing (1)
  • apps/cowswap-frontend/src/entities/bridgeProvider/useBridgeSupportedNetworks.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: shoom3301
PR: cowprotocol/cowswap#5443
File: apps/cowswap-frontend/src/modules/swap/containers/ConfirmSwapModalSetup/index.tsx:71-71
Timestamp: 2025-02-20T15:59:33.749Z
Learning: The swap module in apps/cowswap-frontend/src/modules/swap/ is marked for deletion in PR #5444 as part of the swap widget unification effort.

Learnt from: shoom3301
PR: cowprotocol/cowswap#5787
File: apps/explorer/src/components/orders/BridgeDetailsTable/BridgeDetailsContent/index.tsx:33-40
Timestamp: 2025-06-10T09:57:40.679Z
Learning: In the bridge provider info structure (CrossChainOrder.provider.info), the `website` property is not optional and will always be present, so no conditional checking is needed when accessing `providerInfo.website`.
apps/cowswap-frontend/src/entities/bridgeProvider/useBridgeSupportedNetworks.ts (1) 
Learnt from: shoom3301
PR: cowprotocol/cowswap#5787
File: apps/explorer/src/components/orders/BridgeDetailsTable/BridgeDetailsContent/index.tsx:33-40
Timestamp: 2025-06-10T09:57:40.679Z
Learning: In the bridge provider info structure (CrossChainOrder.provider.info), the `website` property is not optional and will always be present, so no conditional checking is needed when accessing `providerInfo.website`.
🔇 Additional comments (1)
apps/cowswap-frontend/src/entities/bridgeProvider/useBridgeSupportedNetworks.ts (1)

10-12: LGTM! Change properly addresses the cross-widget network loading issue.

The removal of the isBridgingEnabled condition ensures that bridge network information is consistently available across all trade widgets, which fixes the issue where the Account modal lacked swap details when opened from limit/twap/hooks tabs. The SWR key array is appropriately constructed with stable identifiers.

This introduces a minor performance trade-off by always fetching networks regardless of bridging status, but this aligns with the PR objectives of ensuring consistent network data availability.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shoom3301 shoom3301 marked this pull request as ready for review July 3, 2025 12:35
@shoom3301 shoom3301 requested review from a team July 3, 2025 12:35
@shoom3301
Copy link
Collaborator Author

@coderabbitai review

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 3, 2025
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

elena-zh
elena-zh approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor
@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Account data is loaded fine now from any page. Thanks

@shoom3301 shoom3301 merged commit 8c5cd75 into develop Jul 4, 2025
13 of 15 checks passed
@shoom3301 shoom3301 deleted the fix/bridge-networks-loading branch July 4, 2025 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@shoom3301 shoom3301

Labels
Bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @alfetopito @elena-zh
0