8000 chore: fix lint by alfetopito · Pull Request #5911 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: fix lint #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

chore: fix lint #5911

merged 1 commit into from
Jul 1, 2025

Conversation

alfetopito
Copy link
Collaborator
@alfetopito alfetopito commented Jul 1, 2025 •
edited by coderabbitai bot
Loading

Summary

Fix lint broken after #5646 was merged

To Test

  1. Lint should pass

Summary by CodeRabbit

  • Refactor
    • Improved type safety for certain properties, enhancing reliability.
    • Increased readability of interface definitions for better maintainability.

@alfetopito alfetopito self-assigned this Jul 1, 2025
@vercel Vercel
Copy link
vercel bot commented Jul 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ❌ Failed (Inspect) Jul 1, 2025 4:02pm
cowfi ✅ Ready (Inspect) Visit Preview Jul 1, 2025 4:02pm
explorer-dev ✅ Ready (Inspect) Visit Preview Jul 1, 2025 4:02pm
sdk-tools ✅ Ready (Inspect) Visit Preview Jul 1, 2025 4:02pm
swap-dev ✅ Ready (Inspect) Visit Preview Jul 1, 2025 4:02pm
widget-configurator ✅ Ready (Inspect) Visit Preview Jul 1, 2025 4:02pm

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 1, 2025 •
edited
Loading

Walkthrough

The changes update the type definitions in the libs/hook-dapp-lib/src/types.ts file. Explicit line breaks are added for readability in the CoWHookDappActions interface, and the StateDiff interface is made more type-safe by changing property types from any to unknown.

Changes

File(s) Change Summary
libs/hook-dapp-lib/src/types.ts Added line breaks in CoWHookDappActions methods; changed StateDiff property types from any to unknown.

Possibly related PRs

Poem

A hop and a skip through the type fields I go,
Tightening types so bugs never show.
From "any" to "unknown," I leap with delight,
Making the codebase more safe and more right.
With whitespace for clarity, I nibble and play—
Another fine patch for a bright bunny day! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
(node:3284) [DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.
(Use node --trace-deprecation ... to show where the warning was created)
[2/4] Fetching packages...
error nx@21.0.3: The engine "node" is incompatible with this module. Expected version "^20.19.0 || ^22.12.0". Got "24.3.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0af9abb and 44998b5.

📒 Files selected for processing (1)
  • libs/hook-dapp-lib/src/types.ts (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Cypress
🔇 Additional comments (2)
libs/hook-dapp-lib/src/types.ts (2)

36-44: Readability change looks good
Adding the line breaks improves scan-ability without altering the interface surface. No further action needed.

114-115: No unchecked property access found for original or dirty
A search across all .ts files returned no active dot-property, bracket notation, or destructuring usage of .original or .dirty (only a commented TODO). The change from any to unknown will not break existing code.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings fo 8000 r this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alfetopito
Copy link
Collaborator Author

@coderabbitai review

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 1, 2025
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@alfetopito alfetopito marked this pull request as ready for review July 1, 2025 15:58
@alfetopito alfetopito requested a review from a team July 1, 2025 15:59
@alfetopito alfetopito merged commit 61357d7 into develop Jul 1, 2025
13 of 15 checks passed
@alfetopito alfetopito deleted the fix/lint branch July 1, 2025 16:26
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoom3301 shoom3301 shoom3301 approved these changes

@limitofzero limitofzero limitofzero approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfetopito @shoom3301 @limitofzero
0