8000 fix(bridge): use proper naming for eth mainnet by limitofzero · Pull Request #5915 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(bridge): use proper naming for eth mainnet #5915 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(bridge): use proper naming for eth mainnet #5915

wants to merge 1 commit into from
+1 −1

Conversation

limitofzero
Copy link
Contributor
@limitofzero limitofzero commented Jul 2, 2025 •
edited by coderabbitai bot
Loading

Summary

Fixes naming of ETH nework

Details are here: https://www.notion.so/cownation/Wrong-Ethereum-chain-name-21e8da5f04ca802cb28ff1b0328ad2ba

Before:
image

After:
image

To Test

  1. Open swap form on eth and select token for swap. Select destination token with another network f.e. Base. Sign order and check naming on bridging form(or in history)
  • The name of eth network should be "Ethereum" (not Mainnet)

Summary by CodeRabbit

  • Refactor
    • Updated the displayed name for Mainnet from "mainnet" to "ethereum".

@vercel Vercel
Copy link
vercel bot commented Jul 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
explorer-dev ✅ Ready (Inspect) Visit Preview Jul 2, 2025 2:00pm
sdk-tools ✅ Ready (Inspect) Visit Preview Jul 2, 2025 2:00pm
swap-dev ✅ Ready (Inspect) Visit Preview Jul 2, 2025 2:00pm
widget-configurator ✅ Ready (Inspect) Visit Preview Jul 2, 2025 2:00pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
cosmos ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2025 2:00pm

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 2, 2025 •
edited
Loading

Walkthrough

The update changes the name property for the mainnet entry in the CHAIN_INFO map, setting it from 'mainnet' to 'ethereum'. No other properties, logic, or exported/public entity signatures are altered.

Changes

File(s) Change Summary
libs/common-const/src/chainInfo.ts Changed CHAIN_INFO[SupportedChainId.MAINNET].name from 'mainnet' to 'ethereum'

Suggested labels

Bridge

Suggested reviewers

  • elena-zh

Poem

A hop through code, a nimble feat,
"mainnet" now is obsolete.
"Ethereum" shines in its new place,
A subtle shift, a tidy trace.
With every chain, we leap ahead—
CodeRabbit hops where changes led! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
(node:25802) [DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.
(Use node --trace-deprecation ... to show where the warning was created)
[2/4] Fetching packages...
error nx@21.0.3: The engine "node" is incompatible with this module. Expected version "^20.19.0 || ^22.12.0". Got "24.3.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61357d7 and 9b1c95d.

📒 Files selected for processing (1)
  • libs/common-const/src/chainInfo.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Setup
  • GitHub Check: Cypress
🔇 Additional comments (1)
libs/common-const/src/chainInfo.ts (1)

60-65: No hard-coded ‘mainnet’ comparisons found – rename to ‘ethereum’ is safe
A ripgrep search for

  • \.name\s*===\s*['"]mainnet['"]
  • \.name\s*==\s*['"]mainnet['"]
  • case\s*['"]mainnet['"]
    in the repo returned no matches. It appears no logic relies on CHAIN_INFO[id].name === 'mainnet'. Unless there are external consumers (analytics, persisted JSON) depending on the old literal, this rename only affects UI copy and can be merged as is.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

elena-zh
elena-zh approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor
@elena-zh 8000 elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx!

cowdan
cowdan reviewed Jul 2, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowdan cowdan cowdan left review comments

@alfetopito alfetopito alfetopito approved these changes

@shoom3301 shoom3301 shoom3301 approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

< 3B85 div data-show-on-forbidden-error hidden>

Uh oh!

There was an error while loading. Please reload this page.

5 participants
@limitofzero @alfetopito @shoom3301 @elena-zh @cowdan
0