8000 fix(trade): fix quote refetching triggers by shoom3301 · Pull Request #5903 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(trade): fix quote refetching triggers #5903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 30, 2025
Merged

fix(trade): fix quote refetching triggers #5903

merged 12 commits into from
Jun 30, 2025

Conversation

shoom3301
Copy link
Collaborator
@shoom3301 shoom3301 commented Jun 30, 2025 •
edited by coderabbitai bot
Loading

Summary

There is an issue when quote refetching is triggered when it's not expected.
There are two causes:

  1. Since the recent refactoring (feat(trade): display quote refetch indicator #5859), I added a hook usePollQuoteCallback which triggers quote fetching when some of its deps are changed. It should not happen, so the callback was moved to a ref
  2. Quote was refetching when appData changes in confirm modal. It should not happen as well, so I added if (isConfirmOpen) return

To Test

  1. Quote refreshing (when sell amount changes, receiver changes, manual slippages changes)
  2. Permit flow

Bug scenario:

  1. Setup a bridge trade
  2. Go to confirm screen
  3. Expand "Swap bridged via your proxy..."
  4. Click "View your private proxy account +"
  5. Close the modal
  • AR: confirm modal state is reset, quote is refetching
  • ER: no quote refetching, confirm modal state is stable

Summary by CodeRabbit

  • Bug Fixes
    • Improved quote polling behavior to prevent unnecessary updates when the confirmation screen is open, resulting in a more stable and efficient user experience during trades.

fairlighteth and others added 11 commits June 26, 2025 15:13
@fairlighteth
refactor(bridge): improve wording for clarity and readability
da85af8
@fairlighteth
feat(bridge): add collapsible banner for proxy account information
a35e9ba
@fairlighteth
refactor(bridge): migrate InlineBanner to pure components and introdu…
41c1924 
…ce CollapsibleInlineBanner
@fairlighteth
refactor(bridge): simplify toggle logic and improve rendering structure
68eb516
@fairlighteth
refactor(bridge): remove unused utility functions from InlineBanner
4f04bd4
@fairlighteth
feat(bridge): introduce ProxyAccountBanner component for displaying p…
744cfca 
…roxy account information
@fairlighteth
Merge branch 'develop' into fix/cowshed-displaying-style
e10da41
@fairlighteth
Merge branch 'develop' into fix/cowshed-displaying-style
6b6cccd
@fairlighteth
feat(bridge): modify ProxyAccountBanner with modal functionality for …
1e2baa1 
…proxy account details
@shoom3301
Merge branch 'develop' of https://github.com/cowprotocol/cowswap into…
58381ac 
… fix/cowshed-displaying-style
@shoom3301
fix(trade): fix quote refetching triggers
9fdc84e
@shoom3301 shoom3301 requested review from a team June 30, 2025 07:55
@shoom3301 shoom3301 self-assigned this Jun 30, 2025
@vercel Vercel
Copy link
vercel bot commented Jun 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos 🔄 Building (Inspect) Visit Preview Jun 30, 2025 11:20am
cowfi 🔄 Building (Inspect) Visit Preview Jun 30, 2025 11:20am
explorer-dev 🔄 Building (Inspect) Visit Preview Jun 30, 2025 11:20am
sdk-tools 🔄 Building (Inspect) Visit Preview Jun 30, 2025 11:20am
swap-dev 🔄 Building (Inspect) Visit Preview Jun 30, 2025 11:20am
widget-configurator 🔄 Building (Inspect) Visit Preview Jun 30, 2025 11:20am

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 30, 2025 •
edited
Loading

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 0825186 and 5376bdb.

📒 Files selected for processing (1)
  • apps/cowswap-frontend/src/modules/tradeQuote/hooks/useTradeQuotePolling.ts (2 hunks)
 _____________________________________________________________________________________________________________________
< Use a project glossary. Create and maintain a single source of all the specific terms and vocabulary for a project. >
 ---------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shoom3301 shoom3301 mentioned this pull request Jun 30, 2025
Closed
5 tasks
@elena-zh elena-zh mentioned this pull request Jun 30, 2025
Closed
elena-zh
elena-zh approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor
@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Base automatically changed from fix/cowshed-displaying-style to develop June 30, 2025 11:19
@shoom3301 shoom3301 merged commit bfd968c into develop Jun 30, 2025
5 of 13 checks passed
@shoom3301 shoom3301 deleted the fix/quote-refetching branch June 30, 2025 11:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

Assignees

@shoom3301 shoom3301

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @elena-zh @fairlighteth
0