fix(progress-bar): ignore active solvers fl 8000 ag from CMS #5905
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
WalkthroughThe changes update environment filtering logic for solver information, remove the Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to type adjustments and filtering logic without significant control flow modifications. Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
yarn install v1.22.22 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ed6fa4b to
d7ab278
Compare
d7ab278 to
2dc168d
Compare
f77ccfa to
8393af1
Compare
| const envToFilter = isProdLike ? 'prod' : 'staging' | ||
| const envToFilter = isBarnBackendEnv ? 'staging' : 'prod' |
There was a problem hiding this comment.
We were showing prod solvers on barn
| ({ env: solverEnv, chainId: solverChainId, active }) => | ||
| solverEnv === envToFilter && solverChainId === chainId && active, | ||
| ({ env: solverEnv, chainId: solverChainId }) => solverEnv === envToFilter && solverChainId === chainId, |
There was a problem hiding this comment.
No longer filter active solvers
There was a problem hiding this comment.
Just refactoring in this whole file
| const { active, network, environment } = entry.attributes | ||
| const { network, environment } = entry.attributes | ||
| const chainId = network?.data?.attributes?.chainId | ||
| const cmsEnv = environment?.data?.attributes?.name | ||
|
|
||
| // Ignore the ones that are not active | ||
| if (chainId && cmsEnv && active) { | ||
| if (chainId && cmsEnv) { | ||
| // Map to CowEnv | ||
| const env = cmsEnv === 'barn' ? 'staging' : 'prod' | ||
| acc.push({ | ||
| chainId, | ||
| env, | ||
| active, |
There was a problem hiding this comment.
No longer filtering nor storing the active flag.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Doesn't really matter, since we'll match to the response from backend
8393af1 to
730ac7c
Compare
Summary
No longer check for solver
activeflag from CMS.In the UI, we don't really care whether the solver is active or not. After all, we'll match the info received from the backend.
Before this change, if for some reason we forget to mark the solver as enabled in the CMS, it won't show up nicely in the progress bar, even though it's returned by the backend and registered in the CMS.
Now we just need to make sure they are in the CMS, the flag doesn't matter.
To Test
Check the CMS for barn. I have set all Sepolia solvers flag to `false.
Place an order on Sepolia
Summary by CodeRabbit
Refactor
Style
Chores