8000 fix(bridge): display correct destination chain by shoom3301 · Pull Request #5870 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(bridge): display correct destination chain #5870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix(bridge): display correct destination chain #5870

merged 1 commit into from
Jun 23, 2025

Conversation

shoom3301
Copy link
Collaborator
@shoom3301 shoom3301 commented Jun 20, 2025 •
edited by coderabbitai bot
Loading

Summary

Fixes: https://www.notion.so/cownation/Wrong-destination-chain-on-Swap-preview-2168da5f04ca8058b0dbfae38c98a9b2?source=copy_link

image

To Test

See https://www.notion.so/cownation/Wrong-destination-chain-on-Swap-preview-2168da5f04ca8058b0dbfae38c98a9b2?source=copy_link

Summary by CodeRabbit

  • Refactor
    • Updated how the destination chain is determined in the bridge quote context, which may affect which chain data is shown to users.
    • Improved code clarity in the quote details display, with no visible changes to the interface.

@shoom3301 shoom3301 requested review from a team June 20, 2025 07:16
@shoom3301 shoom3301 self-assigned this Jun 20, 2025
@vercel Vercel
Copy link
vercel bot commented Jun 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cowfi ✅ Ready (Inspect) Visit Preview Jun 20, 2025 7:32am
explorer-dev 🛑 Canceled (Inspect) Jun 20, 2025 7:32am
sdk-tools ✅ Ready (Inspect) Visit Preview Jun 20, 2025 7:32am
swap-dev ✅ Ready (Inspect) Visit Preview Jun 20, 2025 7:32am
widget-configurator ✅ Ready (Inspect) Visit Preview Jun 20, 2025 7:32am
1 Skipped Deployment
Name Status Preview Updated (UTC)
cosmos ⬜️ Ignored (Inspect) Jun 20, 2025 7:32am

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 20, 2025 •
edited
Loading

Walkthrough

The changes update the source of the destination chain ID in the bridge quote context logic and adjust the function signature of the QuoteDetails component to explicitly specify its return type. Additionally, some comments and ESLint directives were removed for code clarity.

Changes

File(s) Change Summary
apps/cowswap-frontend/src/modules/bridge/hooks/useQuoteBridgeContext.ts Changed the source of targetChainId from swap to bridge minimum receive amount's chain ID.
apps/cowswap-frontend/src/modules/bridge/pure/QuoteDetails/index.tsx Explicitly declared QuoteDetails return type as ReactNode; removed comments and ESLint lines.

Suggested reviewers

  • elena-zh

Poem

In fields of code where changes sprout,
A chain ID swapped, without a doubt.
A signature made crystal clear,
Old comments gone, the path sincere.
With every hop, this rabbit grins—
For tidy code is where joy begins! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
(node:28199) [DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.
(Use node --trace-deprecation ... to show where the warning was created)
[2/4] Fetching packages...
error nx@21.0.3: The engine "node" is incompatible with this module. Expected version "^20.19.0 || ^22.12.0". Got "24.2.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01eb38e and 3fd8f4c.

📒 Files selected for processing (2)
  • apps/cowswap-frontend/src/modules/bridge/hooks/useQuoteBridgeContext.ts (1 hunks)
  • apps/cowswap-frontend/src/modules/bridge/pure/QuoteDetails/index.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Cypress
  • GitHub Check: Setup
🔇 Additional comments (2)
apps/cowswap-frontend/src/modules/bridge/hooks/useQuoteBridgeContext.ts (1)

32-32: LGTM! Critical fix for destination chain display.

This change correctly fixes the destination chain display issue by using bridgeMinReceiveAmount.currency.chainId instead of swapMinReceiveAmount.currency.chainId. In a bridge operation, the destination chain should be where the bridged tokens will be received, not where the initial swap occurs.

apps/cowswap-frontend/src/modules/bridge/pure/QuoteDetails/index.tsx (1)

29-29: Good TypeScript practice with explicit return type.

Adding the explicit ReactNode return type annotation improves type safety and makes the function signature more self-documenting.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @codera 8000 bbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shoom3301 shoom3301 force-pushed the fix/bridge-route-network branch from 401a11e to 3ba24c1 Compare June 20, 2025 07:16
@shoom3301 shoom3301 force-pushed the fix/bridge-route-network branch from 3ba24c1 to 3fd8f4c Compare June 20, 2025 07:17
elena-zh
elena-zh approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor
@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shoom3301 shoom3301 merged commit 5e2d59a into develop Jun 23, 2025
14 of 15 checks passed
@shoom3301 shoom3301 deleted the fix/bridge-route-network branch June 23, 2025 05:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@shoom3301 shoom3301

Labels
Bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @alfetopito @elena-zh
0