8000 Fix: remove 'new' from cow amm by elena-zh · Pull Request #5879 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: remove 'new' from cow amm #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 23, 2025
Merged

Fix: remove 'new' from cow amm #5879

merged 4 commits into from
Jun 23, 2025

Conversation

elena-zh
Copy link
Contributor
@elena-zh elena-zh commented Jun 23, 2025 •
edited by coderabbitai bot
Loading

Fixes https://cowservices.slack.com/archives/C0361CDG8GP/p1750425431668179

  1. Open the app
  2. Check the menu - 'More' option --> there should not be 'New' label
  3. Expand the menu option --> there should not be 'new' label close to CoW AMM
    image

Summary by CodeRabbit

  • Style
    • Removed the "New" badge and alert styling from the "More" and "CoW AMM" menu items in the navigation.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 23, 2025 •
edited
Loading

Walkthrough

The update removes the "New" badge and its associated alert styling from the "More" and "CoW AMM" menu items in the application's navigation constants. No other changes were made to the menu structure, links, or exported entities.

Changes

File(s) Change Summary
apps/cowswap-frontend/src/modules/application/containers/App/menuConsts.tsx Removed badge and badgeType properties from "More" and "CoW AMM" menu items

Poem

The "New" badge hops away,
No more alerts in the menu today.
CoW AMM and More,
Look as they did before—
Sleek and simple, here to stay!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
(node:26169) [DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.
(Use node --trace-deprecation ... to show where the warning was created)
[2/4] Fetching packages...
error nx@21.0.3: The engine "node" is incompatible with this module. Expected version "^20.19.0 || ^22.12.0". Got "24.2.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 272c918 and 1ffdb80.

📒 Files selected for processing (1)
  • apps/cowswap-frontend/src/modules/application/containers/App/menuConsts.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/cowswap-frontend/src/modules/application/containers/App/menuConsts.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Cypress
  • GitHub Check: Setup
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel Vercel
Copy link
vercel bot commented Jun 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cowfi ✅ Ready (Inspect) Visit Preview Jun 23, 2025 10:45am
explorer-dev 🛑 Canceled (Inspect) Jun 23, 2025 10:45am
swap-dev ✅ Ready (Inspect) Visit Preview Jun 23, 2025 10:45am
3 Skipped Deployments
Name Status Preview Updated (UTC)
cosmos ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2025 10:45am
sdk-tools ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2025 10:45am
widget-configurator ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2025 10:45am

@vercel vercel bot temporarily deployed to Preview – explorer-dev June 23, 2025 09:31 Inactive
@vercel vercel bot temporarily deployed to Preview – cosmos June 23, 2025 09:31 Inactive
@vercel vercel bot temporarily deployed to Preview – sdk-tools June 23, 2025 09:31 Inactive
@vercel vercel bot temporarily deployed to Preview – widget-configurator June 23, 2025 09:31 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer-dev June 23, 2025 09:39 Inactive
@vercel vercel bot temporarily deployed to Preview – widget-configurator June 23, 2025 09:39 Inactive
@elena-zh elena-zh marked this pull request as ready for review June 23, 2025 09:53
@elena-zh elena-zh requested a review from a team June 23, 2025 09:53
coderabbitai[bot]
coderabbitai bot reviewed Jun 23, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/cowswap-frontend/src/modules/application/containers/App/menuConsts.tsx (1)

1-1: Remove unused BadgeTypes import
BadgeTypes is no longer referenced after dropping all badge properties. Cleaning up this import reduces unused code.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e2d59a and 56f163b.

📒 Files selected for processing (1)
  • apps/cowswap-frontend/src/modules/application/containers/App/menuConsts.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Cypress
🔇 Additional comments (2)
apps/cowswap-frontend/src/modules/application/containers/App/menuConsts.tsx (2)

43-45: Removed the "New" badge from the More menu item
The badge and badgeType fields for the "More" entry have been correctly removed to match the updated design.

50-54: Dropped the "New" badge from the CoW AMM submenu item
The CoW AMM link no longer carries the "New" badge or alert styling, aligning with the PR objective.

alfetopito
alfetopito approved these changes Jun 23, 2025
View reviewed changes
@elena-zh @alfetopito
Update apps/cowswap-frontend/src/modules/application/containers/App/m…
272c918 
…enuConsts.tsx

Co-authored-by: Leandro <alfetopito@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – explorer-dev June 23, 2025 10:14 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer-dev June 23, 2025 10:42 Inactive
@elena-zh elena-zh merged commit 3649f81 into develop Jun 23, 2025
13 of 15 checks passed
@elena-zh elena-zh deleted the remove-new-label branch June 23, 2025 10:48
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@alfetopito alfetopito alfetopito approved these changes

@cowdan cowdan cowdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elena-zh @alfetopito @cowdan
0