8000 fix(twap): reduce part size for l2s from 5 to 1 usd by alfetopito · Pull Request #5867 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(twap): reduce part size for l2s from 5 to 1 usd 8000 #5867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

fix(twap): reduce part size for l2s from 5 to 1 usd #5867

merged 1 commit into from
Jun 20, 2025

Conversation

alfetopito
Copy link
Collaborator
@alfetopito alfetopito commented Jun 19, 2025 •
edited by coderabbitai bot
Loading

Summary

Reduce TWAP part size on L2s from $5 to $1

To Test

  1. Open the app on Safe in one of: Gnosis, Arb1, Base, Polygon, Avalanche
  2. Go to TWAP
  3. Pick a sell amount < $5 &gt;= 1$
  • It should be possible to place the order

Summary by CodeRabbit

  • New Features

    • Lowered the minimum part sell amount in fiat currency from 5 USDC to 1 USDC for several supported networks, allowing smaller transactions.

  • Style

    • Reformatted the display of an unsupported wallet message without changing its content.

@vercel Vercel
Copy link
vercel bot commented Jun 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cowfi 🔄 Building (Inspect) Visit Preview Jun 20, 2025 2:13pm
explorer-dev 🔄 Building (Inspect) Visit Preview Jun 20, 2025 2:13pm
swap-dev 🔄 Building (Inspect) Visit Preview Jun 20, 2025 2:13pm
widget-configurator 🔄 Building (Inspect) Visit Preview Jun 20, 2025 2:13pm
2 Skipped Deployments
Name Status Preview Updated (UTC)
cosmos ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2025 2:13pm
sdk-tools ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2025 2:13pm

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 19, 2025 •
edited
Loading

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 217fd08 and 1b36326.

📒 Files selected for processing (1)
  • apps/cowswap-frontend/src/modules/twap/const.ts (2 hunks)
 ___________________________________
< I like big bugs and I cannot lie. >
 -----------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Walkthrough

The minimum part sell amount in fiat currency for several blockchain networks was reduced from 5 USDC to 1 USDC. Additionally, the formatting of the UNSUPPORTED_WALLET_LINK export was changed to a single-line assignment, with no alteration to its value.

Changes

Files Change Summary
apps/cowswap-frontend/src/modules/twap/const.ts Reduced minimum sell amount for multiple chains; reformatted UNSUPPORTED_WALLET_LINK export.

Suggested labels

RELEASE

Poem

A hop and a skip, the numbers drop low,
From five down to one, the sell limits go.
Chains now agree, with a single-line link,
The code is more tidy, or so rabbits think!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alfetopito
Copy link
Collaborator Author

@coderabbitai review

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 19, 2025
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@alfetopito alfetopito force-pushed the fix/twap-part-size branch from cf56af1 to 217fd08 Compare June 20, 2025 10:23
@alfetopito alfetopito self-assigned this Jun 20, 2025
@alfetopito alfetopito marked this pull request as ready for review June 20, 2025 10:30
@alfetopito alfetopito requested review from a team June 20, 2025 10:30
elena-zh
elena-zh approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor
@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@alfetopito alfetopito force-pushed the fix/twap-part-size branch from 217fd08 to 1b36326 Compare June 20, 2025 14:13
@alfetopito alfetopito merged commit d1a2c42 into develop Jun 20, 2025
5 of 12 checks passed
@alfetopito alfetopito deleted the fix/twap-part-size branch June 20, 2025 14:13
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoom3301 shoom3301 shoom3301 approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfetopito @shoom3301 @elena-zh
0