8000 fix: hooks expected order balances diff by jean-neiverth · Pull Request #5681 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: hooks expected order balan 8000 ces diff #5681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

fix: hooks expected order balances diff #5681

merged 1 commit into from
May 13, 2025

Conversation

jean-neiverth
Copy link
Contributor
@jean-neiverth jean-neiverth commented May 12, 2025 •
edited by coderabbitai bot
Loading

Summary

Balances diff on first post hook are being exposed differently of the proposed format (shown here).

Current:

balancesDiff = {
  "account": {
    "0xabc...":"10000"
  },
  ...
}

After this PR:

balancesDiff = {
  "0x123...": {
    "0xabc...":"10000"
  },
  ...
}

Summary by CodeRabbit

  • Refactor
    • Updated balance difference display to use the actual wallet account address for improved accuracy.

@vercel Vercel
Copy link
vercel bot commented May 12, 2025

@jean-neiverth is attempting to deploy a commit to the cow Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 12, 2025 •
edited
Loading

Walkthrough

The change updates the orderExpectedBalanceDiff computation within the useHookBalancesDiff function to return an object keyed by the actual wallet account address in lowercase, instead of the fixed string "account". No public API or exported signature is altered; the update is internal to the hook.

Changes

File(s) Change Summary
apps/cowswap-frontend/src/modules/hooksStore/hooks/useBalancesDiff.ts Modified the return value of orderExpectedBalanceDiff to use the lowercase wallet account address as the key instead of the string "account". No other logic or API signatures changed.

Poem

A hop and a skip, the keys rearrange,
No more "account"—addresses now exchange!
Lowercase and tidy, the mapping is neat,
Rabbits rejoice in this subtle feat.
With every small tweak, the code feels more right,
Balance in keys, and code that’s light!

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef1e8d9 and 0be2a7e.

📒 Files selected for processing (1)
  • apps/cowswap-frontend/src/modules/hooksStore/hooks/useBalancesDiff.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Setup
  • GitHub Check: Cypress
🔇 Additional comments (1)
apps/cowswap-frontend/src/modules/hooksStore/hooks/useBalancesDiff.ts (1)

48-48: Correctly fixed balances diff format to use account address as key.

This change aligns the balances diff object structure with the expected format in the codebase, using the wallet's account address as the key instead of the hardcoded "account" string. The code properly handles the null check for account on line 39, ensuring this code is only reached when account exists.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel Vercel
Copy link
vercel bot commented May 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
sdk-tools ⬜️ Ignored (Inspect) Visit Preview May 12, 2025 0:40am

@shoom3301 shoom3301 merged commit 577d6ea into cowprotocol:develop May 13, 2025
9 of 15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoom3301 shoom3301 shoom3301 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jean-neiverth @shoom3301
0