8000 fix(volume-fee): control safe app fees for stablecoins with ff by shoom3301 · Pull Request #5187 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(volume-fee): control safe app fees for stablecoins with ff #5187

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(volume-fee): control safe app fees for stablecoins with ff #5187

merged 1 commit into from
Dec 12, 2024

Conversation

shoom3301
Copy link
Collaborator

Summary

When isSafeAppStableCoinsFeeEnabled featureflag is off, then Safe Apps fee for stable-stable trades should not be added, otherwise should work as in #5139

@shoom3301 shoom3301 added the RELEASE Included in the release that is being closed label Dec 12, 2024
@shoom3301 shoom3301 requested review from a team December 12, 2024 06:24
@shoom3301 shoom3301 self-assigned this Dec 12, 2024
@vercel Vercel
Copy link
vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 12, 2024 7:32am
cowfi ✅ Ready (Inspect) Visit Preview Dec 12, 2024 7:32am
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 12, 2024 7:32am
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 12, 2024 7:32am
swap-dev ✅ Ready (Inspect) Visit Preview Dec 12, 2024 7:32am
widget-configurator ✅ Ready (Inspect) Visit Preview Dec 12, 2024 7:32am

elena-zh
elena-zh approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor
@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shoom3301 shoom3301 merged commit e7bc7c5 into main Dec 12, 2024
12 of 13 checks passed
@shoom3301 shoom3301 deleted the release/2024-12-12 branch December 12, 2024 07:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
alfetopito
alfetopito reviewed Dec 12, 2024
View reviewed changes
libs/common-const/src/tokens.ts
[SupportedChainId.BASE]: new Set(BASE_STABLECOINS),
}

console.debug('STABLECOINS', STABLECOINS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot something :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito left review comments

@elena-zh elena-zh elena-zh approved these changes

Assignees

@shoom3301 shoom3301

Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @alfetopito @elena-zh
0