8000 Add support for dark mode in Corteza studio by KinyaElGrande · Pull Request #1579 · cortezaproject/corteza · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for dark mode in Corteza studio #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Jan 30, 2024
Merged

Add support for dark mode in Corteza studio #1579

merged 44 commits into from
Jan 30, 2024

Conversation

KinyaElGrande
Copy link
Contributor
@KinyaElGrande KinyaElGrande commented Dec 1, 2023 •
edited
Loading

Dark mode / Multi-theme Support

Ref: #1494

Add support for dark-mode theme and multiple themes on corteza studio.

Additional Changes

  1. Dart-sass installation is checked on server boot up, instead on every request to /custom.css
  2. FE option to return to default color setting on color-picker modal
  3. CSS generation on server boot up.
  4. custom-css has been provisioned to custom-css.general and branding-sass to both theme light and dark themes.

@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-corteza-studio-v2 branch from fb11395 to fe1e53f Compare December 2, 2023 12:42
@KinyaElGrande KinyaElGrande marked this pull request as ready for review December 2, 2023 12:46
@Fajfa Fajfa linked an issue Dec 4, 2023 that may be closed by this pull request
Corteza Studio v2 (Dark mode) #1494
Closed
5 tasks
tjerman
tjerman requested changes Dec 11, 2023
View reviewed changes
Copy link
Member
@tjerman tjerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed it on the code level basis; the structure and stuff, is a bit too much to comprehend. We can take a look at it together at some later point.
So far so good but I'm finding it a bit confusing.

@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-corteza-studio-v2 branch 4 times, most recently from a9d7213 to a90eb03 Compare December 14, 2023 11:02
@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-corteza-studio-v2 branch from a90eb03 to dfb7fab Compare December 18, 2023 10:25
tjerman
tjerman approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member
@tjerman tjerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me; good job man

@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-corteza-studio-v2 branch 4 times, most recently from a0387ee to cbe2e3f Compare December 20, 2023 12:16
@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-corteza-studio-v2 branch from e4012ca to e480f9c Compare December 20, 2023 14:34
@Fajfa Fajfa force-pushed the 2023.9.x-corteza-studio-v2 branch from e480f9c to 7b4e93a Compare December 22, 2023 15:00
@Fajfa Fajfa force-pushed the 2023.9.x-corteza-studio-v2 branch 5 times, most recently from 1998a22 to a0483da Compare January 8, 2024 15:58
@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-corteza-studio-v2 branch 2 times, most recently from 1c5106b to e9183a0 Compare January 18, 2024 08:28
@Fajfa Fajfa force-pushed the 2023.9.x-corteza-studio-v2 branch 3 times, most recently from ab03379 to 0d06982 Compare January 18, 2024 18:17
Fajfa and others added 27 commits January 30, 2024 17:46
@Fajfa @KinyaElGrande
Add active class to c-input-select dropdown option
2be9100
@Fajfa @KinyaElGrande
Remove tooltip from compose builder configurator modal cancel button
08081a9
@KinyaElGrande
Standardize map buttons
e62c4a6
@Fajfa @KinyaElGrande
Adjust CMAP styling for themes
cc99327
@KinyaElGrande
Add color swatchers on color picker component
f82bca2
@Fajfa @KinyaElGrande
Add border-top to card footers
ae690fa
@KinyaElGrande
Add padding-top on discovery main content
4331c93
@Fajfa @KinyaElGrande
Adjust corteza tour styles
1579859
@Fajfa @KinyaElGrande
Adjust topbar theme picker styles
2126953
@Fajfa @KinyaElGrande
Move shared classes from webapp custom.scss to server custom.scss
7bedc78
@Fajfa @KinyaElGrande
Add theme styling to charts
a1665e6
@KinyaElGrande
Fix color picker
25195b5
@Fajfa @KinyaElGrande
Add minor chart theme style changes
27ef033
@KinyaElGrande
Add theme translations on topbar
40cfe09
@Fajfa @KinyaElGrande
Adjust CInputColorPicker theme variable styles
2aafdc6
@Fajfa @KinyaElGrande
Add noninteractive to tooltips
5951811
@KinyaElGrande
Update provisioning for light and extra-light
eded8d8
@Fajfa @KinyaElGrande
Add theming to Admin dashboard chart
a7147cb
@Fajfa @KinyaElGrande
Adjust report dark theme styles
8fb5c36
@Fajfa @KinyaElGrande
Add theme support to workflows
3b4dff9
@Fajfa @KinyaElGrande
Add labels to color picker theme variables
9a4e1fa
@Fajfa @KinyaElGrande
Fix initial render sometimes not being responsive on metric, calendar…
b79b61a 
… and cmap
@Fajfa @KinyaElGrande
Visually update RecordOrganizerBase
9c425b3
@Fajfa @KinyaElGrande
Change chart axis line styles to extra-light
a78d399
@Fajfa @KinyaElGrande
Change default extra-light color to match designs (#768D9A with 0.5 o…
001afe2 
…pacity on bg #0B344E is #3E5A6F
@KinyaElGrande
Add dark-mode on minified default custom css
c25d759
@KinyaElGrande
Add text-dark on sass-install link
288a412
@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-corteza-studio-v2 branch from 00f7ff3 to 288a412 Compare January 30, 2024 14:46
@KinyaElGrande KinyaElGrande merged commit d343b38 into 2023.9.x Jan 30, 2024
@KinyaElGrande KinyaElGrande deleted the 2023.9.x-corteza-studio-v2 branch January 30, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fajfa Fajfa Awaiting requested review from Fajfa

@tjerman tjerman Awaiting requested review from tjerman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Corteza Studio v2 (Dark mode)
3 participants
@KinyaElGrande @tjerman @Fajfa
0