chore: refactor runner configuration #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzipi
previously approved these changes
Jun 6, 2025
The `check` package is only used from the `runner` package. It makes sense to use `TestRunContext` and other types in `check` but that is not possible due to circular imports. Make `check` part of `runner` instead. In addition, to reduce issues with cyclic imports and confusion between different configuration objects, the `RunnerConfig` now consolidates all configuration data for the test runner.
0bf9f43 to
42f1386
Compare
fzipi
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
checkpackage is only used from therunnerpackage. It makes sense to useTestRunContextand other types incheckbut that is not possible due to circular imports. Makecheckpart ofrunnerinstead.In addition, to reduce issues with cyclic imports and confusion between different configuration objects, the
RunnerConfignow consolidates all configuration data for the test runner.