8000 chore: set min go version to `v1.22` by M4tteoP · Pull Request #374 · coreruleset/go-ftw · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: set min go version to v1.22 #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore: set min go version to v1.22 #374

merged 1 commit into from
Oct 17, 2024

Conversation

M4tteoP
Copy link
Member
@M4tteoP M4tteoP commented Oct 16, 2024

This PR proposes downgrading the Go version to v1.22, following the recent bump from v1.21 to v1.23 happened in #369. This because:

  • It doesn't appear to be an immediate need for v1.23 (I'm thinking about new features or dependencies requiring it).
  • It would allow projects importing go-ftw more time to upgrade to the most recent Go version, still allowing them to adopt recent go-ftw versions in the meantime. For example, Coraza follows a policy of supporting the last two Go releases, so the adoption of newer go-ftw versions would slow down.
  • Why v1.22 and not back to v1.21? No strong opinion here:
    • It would still upgrade the go version, just more gradually.
    • It would align with the go version we have in crs-toolchain (I guess not that important to have consistency here 😅)

Also, adds expected Go version details to renovatebot repo configs.

@M4tteoP M4tteoP marked this pull request as ready for review October 16, 2024 20:27
@fzipi fzipi merged commit 655ff91 into main Oct 17, 2024
4 checks passed
@fzipi fzipi deleted the go1.22 branch October 17, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0