feat(config): adds override_empty_host_header flag #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
previously approved these changes
Feb 21, 2023
jcchavezs
reviewed
Feb 21, 2023
theseion
requested changes
Feb 22, 2023
theseion
requested changes
Feb 22, 2023
fzipi
reviewed
Mar 1, 2023
Allows a default Host header to be set in the `testoverride` section of
the config:
```
---
testoverride:
dest_addr: some.example.org
input:
headers:
Host: another.example.org
```
It will take precedense over `dest_addr` if it is specified as well. It
will only be set if the input stage does not already have a host header
set.
Falling back to using the DestAddr override if it's not specified.
M4tteoP
commented
Mar 28, 2023
M4tteoP
commented
Mar 28, 2023
theseion
requested changes
Mar 28, 2023
theseion
approved these changes
Mar 29, 2023
fzipi
approved these changes
Mar 29, 2023
|
Aaaaaaaaweeeeesoooommmmeeeeee
…On Wed, 29 Mar 2023, 14:05 Felipe Zipitría, ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks for putting this together! LGTM.
—
Reply to this email directly, view it on GitHub
<#132 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYAWIWBLJ2W4YVGWRZT3W6QQQPANCNFSM6AAAAAAVDOOKHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Great work! If possible, Please release a new version 👍 |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature added in #63 replaces the empty host field with the destination address. It has conflicts with some CRS test that are trying to send on purpose empty or missing host headers.
It happens only when
dest_addroverride is in place, for this reason CRS tests against apache are still running smoothly.This PR implements @theseion idea, adding the
override_empty_host_headerflag that enables this feature, permitting, by default, to keep running CRS tests as intended.More context in the issue: #129.
Thanks the feedbacks!
tentatively closes #129