8000 Reformat as testify by fzipi · Pull Request #162 · coreruleset/go-ftw · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Reformat as testify #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 10, 2023
Merged

Reformat as testify #162

merged 18 commits into from
Jun 10, 2023

Conversation

fzipi
Copy link
Member
@fzipi fzipi commented May 29, 2023

This reformat uses only testify for testing.

Major changes from the previous testing platform:

  • Test names are used for getting files and or maps for tests that require it. This way we can use BeforeTest consistently for setting up tests.
  • text/template is used for simplifying files handling. This probably could be optimized ever more.
  • tests in the runner directory have been split
  • added a new httpsTestServer for testing locally instead of calling remote hosts. this change also implied a change by adding SetRootCAs in the client.

Fixes #106.

fzipi added 12 commits June 4, 2023 12:31
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi force-pushed the reformat-as-testify branch from 76e7213 to 8d7fd0f Compare June 4, 2023 15:31
@fzipi fzipi marked this pull request as ready for review June 4, 2023 15:32
@fzipi fzipi requested a review from theseion June 4, 2023 15:38
fzipi added 2 commits June 4, 2023 13:39
Signed-off-by: Felipe Zipitr
8000
ia <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Copy link
Collaborator
@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew! That took longer than expected ;)

Thanks!

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi requested a review from theseion June 4, 2023 23:56
fzipi and others added 3 commits June 6, 2023 22:46
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi requested a review from theseion June 9, 2023 21:58
@fzipi fzipi merged commit c864424 into main Jun 10, 2023
@fzipi fzipi deleted the reformat-as-testify branch June 10, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reformat test as testify/suite
2 participants
0