8000 chore: use python only by fzipi · Pull Request #2 · coreruleset/crs-linter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: use python only #2

N 8000 ew issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2025
Merged

chore: use python only #2

merged 4 commits into from
Jan 20, 2025

Conversation

fzipi
Copy link
Member
@fzipi fzipi commented Jan 19, 2025

what

  • make code independent of directory
  • use python tools only instead of depending on shell and git cmd
  • add positive and negative tests for all features

why

  • make features isolated from CRS
  • testing!

@fzipi
chore: use python only
868ceca 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi marked this pull request as ready for review January 19, 2025 18:14
@fzipi
Copy link
Member Author
fzipi commented Jan 19, 2025

@airween Can you help me with the failing tests here?

airween
airween requested changes Jan 19, 2025
View reviewed changes
@fzipi
fix: tests
e54a4b5 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
fzipi
fzipi commented Jan 19, 2025
View reviewed changes
@fzipi fzipi requested a review from airween January 19, 2025 23:00
airween
airween previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor
@airween airween left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now it's good. LGTM.

fzipi
fzipi commented Jan 20, 2025
View reviewed changes
@fzipi
fix: downgrade semver version
a866dd2 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi merged commit aa63464 into main Jan 20, 2025
8 checks passed
@fzipi fzipi deleted the chore/replace-shell-pure-python branch January 20, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airween airween airween left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzipi @airween
0