8000 chore: update restricted-upload-data with crs-toolchain by S0obi · Pull Request #4117 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: update restricted-upload-data with crs-toolchain #4117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

S0obi
Copy link
Contributor
@S0obi S0obi commented May 5, 2025
  • Update the documentation on how to generate restricted-upload-data with crs-toolchain
  • Refresh the data file from restricted-files.data

See previous discussion in #4106

Copy link
Contributor
github-actions bot commented May 5, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

# done <<<"${words}"
# }' rules/restricted-files.data | sort | uniq > "$tmpfile"
# crs-toolchain util fp-finder "$tmpfile" -e english-extended.txt >> rules/restricted-upload.data
# rm -f "$tmpfile"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# rm -f "$tmpfile"
# rm -f "$tmpfile" english-extended.txt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated the file on my machine and the ordering changed. Please rerun the update snippet and update the PR.

@fzipi
Copy link
Member
fzipi commented Jun 19, 2025

Hi @S0obi! Are you up for finishing this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0