8000 fix: tag inconsistency per file by Xhoenix · Pull Request #4031 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: tag inconsistency per file #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 29, 2025
Merged

fix: tag inconsistency per file #4031

merged 8 commits into from
Mar 29, 2025

Conversation

Xhoenix
Copy link
Member
@Xhoenix Xhoenix commented Mar 3, 2025

Fixes #3991

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 3, 2025 •
edited
Loading

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi mentioned this pull request Mar 3, 2025
Closed
@Xhoenix Xhoenix requested review from fzipi and theseion March 5, 2025 05:55
@fzipi
Copy link
Member
fzipi commented Mar 5, 2025

This probably must come with a new lint for the proper tags... 🤔

@airween
Copy link
Contributor
airween commented Mar 5, 2025

Yes, definitely.

May I add a new one to the current (old) linter?

@fzipi
Copy link
Member
fzipi commented Mar 5, 2025

@airween Better to add it to the new instead?

@airween
Copy link
Contributor
airween commented Mar 5, 2025

@airween Better to add it to the new instead?

I can do that later. Could you open a new issue under linter's repository?

@fzipi fzipi mentioned this pull request Mar 5, 2025
Closed
@fzipi fzipi mentioned this pull request Mar 24, 2025
Merged
@Xhoenix
8000
Copy link
Member Author
Xhoenix commented Mar 28, 2025

It'd be nice if this gets merged before the end of March. 😅

fzipi
fzipi reviewed Mar 28, 2025
View reviewed changes
Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I would do is to order the new tags after the 'tag:OWASP_CRS'...

@airween
Copy link
Contributor
airween commented Mar 28, 2025

The only change I would do is to order the new tags after the 'tag:OWASP_CRS'...

Should the linter check this condition? I start to implement this new feature soon...

@fzipi
Copy link
Member
fzipi commented Mar 28, 2025

We can, I mean, it won't hurt 😄

@Xhoenix
Copy link
Member Author
Xhoenix commented Mar 28, 2025

I fixed the tag order. 😊

fzipi
fzipi approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xhoenix Xhoenix added this pull request to the merge queue Mar 29, 2025
Merged via the queue into coreruleset:main with commit d8e1c7b Mar 29, 2025
6 checks passed
@Xhoenix Xhoenix deleted the tag-consistency-per-file branch March 29, 2025 01:35
@airween airween mentioned this pull request Mar 30, 2025
Merged
@fzipi fzipi mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

@theseion theseion Awaiting requested review from theseion

Assignees
No one assigned
Labels
release:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add common tag for all rules in a file
3 participants
@Xhoenix @fzipi @airween
0