fix(test): move xss test from 942180 to 941330 #4012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
theseion
requested changes
Feb 24, 2025
tests/regression/tests/REQUEST-941-APPLICATION-ATTACK-XSS/941330.yaml
Outdated
Show resolved
Hide resolved
…30.yaml Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
|
Looks good but tests are failing. |
a2c4db5 to
acb8e1b
Compare
acb8e1b to
c27f145
Compare
theseion
reviewed
Mar 26, 2025
| @@ -36,3 +36,20 @@ tests: | |||
| output: | |||
| log: | |||
| expect_ids: [941330] | |||
| - test_id: 3 | |||
There was a problem hiding this comment.
I think this is the wrong rule for the test. 941330 is "IE XSS filter" and the regex will never match anything that looks like the payload in this test. Rather 941210 maybe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references