8000 chore: add quant as comment by fzipi · Pull Request #3925 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: add quant as comment #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: add quant as comment #3925

wants to merge 3 commits into from

Conversation

fzipi
Copy link
Member
@fzipi fzipi commented Nov 3, 2024

This is a test.

@fzipi
chore: add quant as comment
f6a967b 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi force-pushed the add-quantum-table branch 3 times, most recently from 56ec2be to 88749f3 Compare November 4, 2024 12:25
@fzipi
debug: echo output
a05a2c7 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi force-pushed the add-quantum-table branch 7 times, most recently from cd4bcbb to af851bd Compare November 4, 2024 14:12
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Nov 4, 2024 •
edited
Loading

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi force-pushed the add-quantum-table branch 2 times, most recently from 844ab59 to e68d44a Compare November 4, 2024 14:47
@fzipi
chore: update ftw version
6ab33b5 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi force-pushed the add-quantum-table branch from e68d44a to 6ab33b5 Compare November 4, 2024 14:56
@fzipi fzipi mentioned this pull request Nov 18, 2024
Closed
@M4tteoP
Copy link
Member
M4tteoP commented Nov 18, 2024 •
edited
Loading

Following #3927, it could be nice to have this table inside another expandable content before the diff. With a final message that could look something like this:

⚠️ Quantitative testing detected new false positives
📝 Total false positives: 408 -> 10407

Run details

Time to run tests: ms
Total tests:
False positives:

False positives per rule:

key value
920220 198
920221 198
932235 4
932270 2
932380 2
933160 1
942100 1
942230 1
942360 1
Diff details 

3c3
<   "falsePositives": 408,
---
>   "falsePositives": 10407,
10c10
<     "933160": 1,
---
>     "933160": 10000,
15c15
<   "totalTime": 7355236987
---
>   "totalTime": 9614894260

@dune73
Copy link
Member
dune73 commented Nov 18, 2024

I quite like @M4tteoP's idea.

@fzipi
Copy link
Member Author
fzipi commented Nov 18, 2024

Beautiful.

@fzipi
Copy link
Member Author
fzipi commented Nov 26, 2024

@M4tteoP This was superseded? I'm lost now 😄

@M4tteoP
Copy link
Member
M4tteoP commented Nov 26, 2024

This was superseded?

Not entirely, this PR introduces the details of the quantitative run as a table, which is a nice enhancement to have in another expandable content for every run

@fzipi fzipi mentioned this pull request Dec 2, 2024
Closed
@github-actions github-actions bot added the Stale label Dec 27, 2024
@fzipi fzipi removed the Stale label Jan 3, 2025
@fzipi fzipi mentioned this pull request Jan 6, 2025
Closed
@github-actions github-actions bot added the Stale label Feb 3, 2025
@Xhoenix Xhoenix removed the Stale label Feb 3, 2025
@fzipi fzipi mentioned this pull request Feb 2, 2025
Closed
@fzipi fzipi mentioned this pull request Mar 3, 2025
Closed
@github-actions github-actions bot added the Stale label Mar 6, 2025
@github-actions github-actions bot closed this Mar 20, 2025
@theseion theseion reopened this Mar 20, 2025
@github-actions github-actions bot removed the Stale label Mar 21, 2025
@fzipi fzipi mentioned this pull request Apr 7, 2025
Open
@github-actions github-actions bot added the Stale label Apr 20, 2025
@Xhoenix Xhoenix removed the Stale label Apr 27, 2025
@fzipi fzipi mentioned this pull request May 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fzipi @M4tteoP @dune73 @theseion @Xhoenix
0