8000 ci: do not run pipeline twice by fzipi · Pull Request #3832 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: do not run pipeline twice #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 9, 2024
Merged

ci: do not run pipeline twice #3832

merged 8 commits into from
Oct 9, 2024

Conversation

fzipi
Copy link
Member
@fzipi fzipi commented Sep 25, 2024 •
edited
Loading
  • prevent pipelines to run twice every time.
  • remove linelint action that takes too much time, use pre-commit action instead
  • cleaned up space and eol by running pre-commit run -a locally

Should fix #3829.

@fzipi
ci: run only once per pr/push
ca896a0 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi changed the title Chore/do not run twice ci: do not run pipeline twice Sep 25, 2024
@fzipi fzipi added the ⚠️ do not merge Additional work or discussion is needed despite passing tests label Sep 25, 2024
@fzipi fzipi force-pushed the chore/do-not-run-twice branch from 4574111 to fc25f98 Compare September 25, 2024 13:01
@fzipi
fix: shellcheck lint file
d971d57 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi force-pushed the chore/do-not-run-twice branch from fc25f98 to d971d57 Compare September 25, 2024 13:09
@fzipi
fix: white space and eol
1bdb090 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi
ci: remove linelint and use pre-commit instead
1df6290 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi
docs: add comment on pre-commit action
032c426 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi
fix: add back setuptools for python
6064460 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi added release:ignore Ignore for changelog release 🔧 ci/cd and removed ⚠️ do not merge Additional work or discussion is needed despite passing tests labels Sep 25, 2024
@fzipi fzipi requested review from theseion and airween September 25, 2024 13:55
@fzipi fzipi mentioned this pull request Oct 7, 2024
Closed
theseion
theseion reviewed Oct 9, 2024
View reviewed changes
@fzipi fzipi added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit ef2813d Oct 9, 2024
5 checks passed
@fzipi fzipi deleted the chore/do-not-run-twice branch October 9, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

@airween airween Awaiting requested review from airween

Assignees
No one assigned
Labels
release:ignore Ignore for changelog release 🔧 ci/cd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI/CD: Do not run twice the same job on push and pull_request
2 participants
@fzipi @theseion
0