feat: add product name tags #3815
Conversation
|
Hi @TimDiam0nd, thanks for the PR. First of all, could you take a look at this lintian error? Seems like the (But perhaps this is a typo, I'm not sure you want to add a tag with name |
|
Hey, apologies about that, that should be fixed now (i initially wasnt aware of the approved tags list). Happy to rename the nodejs tag to something else if you would like |
No worries, thanks for contributing.
But what would be good to explain in the PR's summary is how did you collect the rules what need to have these tags. |
Sorry, now I see that tag had already added. |
PR Summary updated as per above |
|
Open questions from today's issues meeting:
I'll dig in a bit further and try to answer some of these questions. A lot of this was implemented before, I think, any of the current devs were involved in CRS, so it might involve some CRS archaeology 🕵️ 🔎 |
|
Re-opening as this is unresolved and we decided to investigate it further. |
|
📊 Quantitative test results for language: |
Added tags for internet explorer and node js related rules.
Tags have been chosen based off the value in
msgi.e. the internet explorer tags have been added to rules that contain "IE" in themsgfield