8000 fix: old test schema field in 932239.yaml by TimDiam0nd · Pull Request #3847 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: old test schema field in 932239.yaml #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2024
8000
Merged

fix: old test schema field in 932239.yaml #3847

merged 1 commit into from
Oct 7, 2024

Conversation

TimDiam0nd
Copy link
Contributor

No description provided.

@fzipi fzipi added the release:ignore Ignore for changelog release label Oct 7, 2024
@fzipi fzipi added this pull request to the merge queue Oct 7, 2024
Merged via the queue into coreruleset:main with commit 2ba651a Oct 7, 2024
4 checks passed
@mtaket
Copy link
Contributor
mtaket commented Oct 7, 2024

@TimDiam0nd Shouldn't it be:

output:
log:
no_expect_ids: [932239]

@TimDiam0nd
Copy link
Contributor Author

@TimDiam0nd Shouldn't it be:

output: log: no_expect_ids: [932239]

Ah good spot, will get that fixed shortly

@fzipi fzipi mentioned this pull request Oct 7, 2024
Closed
@fzipi
Copy link
Member
fzipi commented Oct 7, 2024

Ugh, bad quick review 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

50D3
Assignees
No one assigned
Labels
release:ignore Ignore for changelog release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimDiam0nd @mtaket @fzipi
0