8000 fix(933150): moving printf to 933160 for additional php syntax check (933150 PL-1, 933160 PL-1) by EsadCetiner · Pull Request #3840 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(933150): moving printf to 933160 for additional php syntax check (933150 PL-1, 933160 PL-1) #3840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix(933150): moving printf to 933160 for additional php syntax check (933150 PL-1, 933160 PL-1) #3840

wants to merge 10 commits into from

Conversation

EsadCetiner
Copy link
Member

Fixes a false positive with printf matching SprintForTheCause by moving it to 933160 which checks for additional PHP syntax instead of just printf.

closes #3641

@EsadCetiner EsadCetiner mentioned this pull request Oct 2, 2024
Open
1 task
@RedXanadu RedXanadu self-requested a review October 2, 2024 13:22
@fzipi fzipi mentioned this pull request Oct 7, 2024
Closed
@fzipi fzipi mentioned this pull request Nov 18, 2024
Closed
@github-actions github-actions bot added the Stale label Nov 26, 2024
@EsadCetiner EsadCetiner removed the Stale label Nov 26, 2024
@fzipi fzipi mentioned this pull request Dec 2, 2024
Closed
@github-actions github-actions bot added the Stale label Dec 27, 2024
@EsadCetiner EsadCetiner removed the Stale label Dec 29, 2024
@fzipi fzipi mentioned this pull request Jan 6, 2025
Closed
@github-actions github-actions bot added the Stale label Jan 29, 2025
@Xhoenix Xhoenix removed the Stale label Feb 3, 2025
@fzipi fzipi mentioned this pull request Feb 2, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Feb 25, 2025 •
edited
Loading

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi changed the title fix: SprintForTheCause false positive by moving printf to 933160 (933150 PL-1, 933160 PL-1) fix(933150): moving printf to 933160 for additional php syntax check (933150 PL-1, 933160 PL-1) Feb 27, 2025
@fzipi fzipi mentioned this pull request Mar 3, 2025
Closed
@github-actions github-actions bot added the Stale label Mar 31, 2025
@Xhoenix Xhoenix removed the Stale label Apr 7, 2025
@fzipi fzipi mentioned this pull request Apr 7, 2025
Open
@fzipi fzipi mentioned this pull request May 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi left review comments

@RedXanadu RedXanadu Awaiting requested review from RedXanadu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule 933150 Has False Positive for URLs
4 participants
@EsadCetiner @fzipi @Xhoenix @RedXanadu
0