8000 fix: fp with user-agent containing ; pg (932239 PL2) by franbuehler · Pull Request #3727 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fp with user-agent containing ; pg (932239 PL2) #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 16, 2024
Merged

fix: fp with user-agent containing ; pg (932239 PL2) #3727

merged 6 commits into from
Sep 16, 2024

Conversation

franbuehler
Copy link
Contributor
@franbuehler franbuehler commented Jun 1, 2024 •
edited
Loading

This PR resolves #3725 by adding a @ to pg to the file unix-shell-upto3.ra. It also adds a test.

@franbuehler franbuehler changed the title fix: fp with user-agent containing ; pgt (932239 PL2) fix: fp with user-agent containing ; pg (932239 PL2) Jun 1, 2024
@azurit
Copy link
Member
azurit commented Jun 2, 2024

What exactly will this PR cause? Will it exclude pg, pg@ and pg~ from regex assembling?

@franbuehler
Copy link
Contributor Author

What exactly will this PR cause? Will it exclude pg, pg@ and pg~ from regex assembling?

Yes, exactly.

@azurit
Copy link
Member
azurit commented Jun 2, 2024

That doesn't seems fully correct to me, as we are having FPs with PGT- and not with, for example, pg (with a space at the end).

@franbuehler
Copy link
Contributor Author
franbuehler commented Jun 3, 2024 •
edited
Loading

Yes, true. So, to match pgt but not pg, I'll add ~ but not @ to the exclusion file. I'll remove the pg@ AND pg, right?

@dune73 dune73 mentioned this pull request Jun 3, 2024 8000
Closed
@franbuehler
Copy link
Contributor Author

I don't know why test 932300 is failing. I had to run crs-toolchain regex update --all and used the latest crs-toolchain.

@EsadCetiner EsadCetiner mentioned this pull request Jun 18, 2024
Merged
@fzipi fzipi mentioned this pull request Jul 1, 2024
Closed
@github-actions github-actions bot added the Stale label Jul 18, 2024
@github-actions github-actions bot closed this Aug 1, 2024
@fzipi fzipi reopened this Sep 16, 2024
@fzipi fzipi force-pushed the fix-932239-useragent branch from cdf77be to 3d99114 Compare September 16, 2024 12:47
@fzipi
run crs-toolchain regex update --all
df3ebb8 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi force-pushed the fix-932239-useragent branch from 3d99114 to df3ebb8 Compare September 16, 2024 12:52
fzipi
fzipi approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzipi fzipi requested a review from azurit September 16, 2024 13:08
@RedXanadu RedXanadu removed the Stale label Sep 16, 2024
RedXanadu
RedXanadu approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member
@RedXanadu RedXanadu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense. New test looks good.

@fzipi fzipi added this pull request to the merge queue Sep 16, 2024
Merged via the queue into coreruleset:main with commit a419ffa Sep 16, 2024
4 checks passed
@fzipi fzipi mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

@RedXanadu RedXanadu RedXanadu approved these changes

@azurit azurit Awaiting requested review from azurit

Assignees
No one assigned
Labels
release:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

932239 blocking Mozilla user-agents | Matched Data: ; PG found
4 participants
@franbuehler @azurit @fzipi @RedXanadu
0