8000 fix: use proper capture for log output of 932300 by theseion · Pull Request #3763 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: use proper capture for log output of 932300 #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: use proper capture for log output of 932300 #3763

merged 1 commit into from
Jul 9, 2024

Conversation

theseion
Copy link
Contributor
@theseion theseion commented Jul 7, 2024

932300 should have the capture action since TX.0 is used in logdata. Currently, TX.0 will simply contain the last value assigned to it by any previously run rule.

Fixes #3761

@theseion theseion requested a review from fzi 8000 pi July 7, 2024 14:33
@theseion
fix: use proper capture for log output of 932300
872cadb 
932300 should have the `capture` action since `TX.0` is used in
`logdata`. Currently, `TX.0` will simply contain the last value assigned
to it by any previously run rule.

Fixes coreruleset#3761
@theseion theseion requested a review from a team July 9, 2024 04:56
EsadCetiner
EsadCetiner approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member
@EsadCetiner EsadCetiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dune73 dune73 added this pull request to the merge queue Jul 9, 2024
Merged via the queue into coreruleset:main with commit dc0c37e Jul 9, 2024
4 checks passed
@theseion theseion deleted the fix-log-output branch July 9, 2024 16:09
@fzipi fzipi mentioned this pull request Jul 23, 2024
Merged
@airween airween mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dune73 dune73 dune73 approved these changes

@EsadCetiner EsadCetiner EsadCetiner approved these changes

@fzipi fzipi Awaiting requested review from fzipi

Assignees
No one assigned
Labels
release:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

932300 reports wrong match in log
4 participants
@theseion @dune73 @EsadCetiner @fzipi
0