fix: replace $upstream variable with BACKEND env var
#331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`proxy_pass` will use the resolver whenever the argument contains variables. This isn't usually an issue but it can be if hosts are declared via `/etc/hosts`, e.g. when useing `extra_hosts` from docker compose. Then, `/etc/hosts` would not be considered. Use the `BACKEND` variable directly to avoid use of the resolver. Fixes coreruleset#330
fzipi
approved these changes
Feb 6, 2025
|
Thanks so much! Just to elaborate (because it took me a real long time on Google to figure this out), if proxy_pass sees a variable as its parameter, it will no longer consider /etc/hosts when resolving a host, and only refer the DNS resolver it's been configured to resolve hosts. If proxy_pass sees a literal as its parameter, it will consider /etc/hosts first before referring to the DNS resolver. This is important if you depend on extra_hosts for your container to function correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proxy_passwill use the resolver whenever the argument contains variables. This isn't usually an issue but it can be if hosts are declared via/etc/hosts, e.g. when useingextra_hostsfrom docker compose. Then,/etc/hostswould not be considered.Use the
BACKENDvariable directly to avoid use of the resolver.Fixes #330