feat(apache): switch to pcre2 #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e031f13 to
e4eceea
Compare
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
0e61abb to
d8c4546
Compare
|
Note that the failing test in the httpd builds is ok. The test has an override to make it work on the CI, which will no longer be necessary once we update to the new images. I'll push a change to CRS to update the override so this PR can be properly verified. |
airween
requested changes
Mar 5, 2025
05d65d8 to
15150ca
Compare
15150ca to
e52d587
Compare
nginx-alpine builds don't flush the log reliably. Refs coreruleset/go-ftw#473
|
@fzipi ready for review. |
|
We need an extra approver... |
|
I've added @airween to the containers team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pcre2 for building on apache