dracut: Ignore module when building kdump initrd #2090
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: coreos/fedora-coreos-tracker#1832 Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
8000
|
I don't think this should live upstream. We already return 255 here so we'll only be included if we're pulled in. So coreos/fedora-coreos-config#3538 should be sufficient. |
|
Thanks for the review. I think I was testing incorrectly as dracut was unconditionally including this module. On testing again, dracut does seem to be ignoring this module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: coreos/fedora-coreos-tracker#1832