8000 tests/kola/kdump: Check for ignition modules in kdump intird by Johan-Liebert1 · Pull Request #3549 · coreos/fedora-coreos-config · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tests/kola/kdump: Check for ignition modules in kdump intird #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an iss 8000 ue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: testing-devel
Choose a base branch
from

Conversation

Johan-Liebert1
Copy link
Member

After #3538 ignition and dracut modules should not be included in the kdump initrd. This adds a test to ensure the same.

Copy link
Member
@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks but overall LGTM

fi

# Test that ignition/afterburn modules are not present in the kdump initramfs
if lsinitrd --mod "${kdump_path}" | grep -q ignition; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can save the list in a variable to avoid re-opening the file for the next test

After coreos#3538 ignition and dracut modules should not be included in
the kdump initrd. This adds a test to ensure the same.

Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Copy link
Member
@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Johan-Liebert1
Copy link
Member Author

Test failed as it needs coreos/afterburn#1216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0